From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9564 invoked by alias); 19 Feb 2013 09:13:43 -0000 Received: (qmail 9526 invoked by uid 22791); 19 Feb 2013 09:13:42 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BF X-Spam-Check-By: sourceware.org Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Feb 2013 09:13:37 +0000 Received: by mail-wi0-f175.google.com with SMTP id l13so4514878wie.8 for ; Tue, 19 Feb 2013 01:13:35 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.7.232 with SMTP id m8mr23615888wia.8.1361265215623; Tue, 19 Feb 2013 01:13:35 -0800 (PST) Received: by 10.194.56.100 with HTTP; Tue, 19 Feb 2013 01:13:35 -0800 (PST) In-Reply-To: <51225EBE.1050509@ubuntu.com> References: <511A35DC.7060207@ubuntu.com> <51225EBE.1050509@ubuntu.com> Date: Tue, 19 Feb 2013 09:13:00 -0000 Message-ID: Subject: Re: [patch] [libffi] do not install libffi library, headers and documentation From: Richard Biener To: Matthias Klose Cc: GCC Patches , GCJ-patches , "libffi-discuss@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2013-q1/txt/msg00016.txt.bz2 On Mon, Feb 18, 2013 at 6:02 PM, Matthias Klose wrote: > Am 12.02.2013 13:45, schrieb Richard Biener: >> On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener >> wrote: >>> On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose wrote: >>>> The libffi library, headers and documentation are still installed, although >>>> libffi provides separate releases for a long time. So do not install these >>>> anymore as part of a GCC install. Tested with a build and an install with go >>>> and java enabled (both using libffi_convenience). Ok for the trunk? >>> >>> openSUSE is using the GCC provided libffi, so no, this is not ok (not at this >>> stage anyway). Also proper not-installing libffi would work by disabling >>> the maybe-install-target-libffi at the toplevel, not changing libffi makfiles >>> (which are supposed to be imported from upstream, no?) >> >> Thus, add no_install= true; to the libffi target module > > updated patch attached, checked with a make install that no ffi headers and > libraries are installed. If not ok for 4.8, ok for 4.9 when it opens? I'm fine with that variant but I'd like to see another ok. No preference as to whether to target 4.8 or 4.9. Richard. > Matthias >