From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20639-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1054 invoked by alias); 12 Feb 2013 12:46:05 -0000
Received: (qmail 973 invoked by uid 22791); 12 Feb 2013 12:46:04 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BF
X-Spam-Check-By: sourceware.org
Received: from mail-we0-f178.google.com (HELO mail-we0-f178.google.com) (74.125.82.178)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Feb 2013 12:45:58 +0000
Received: by mail-we0-f178.google.com with SMTP id x48so22995wey.37        for <multiple recipients>; Tue, 12 Feb 2013 04:45:56 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.194.77.129 with SMTP id s1mr13591344wjw.17.1360673146051; Tue, 12 Feb 2013 04:45:46 -0800 (PST)
Received: by 10.194.179.130 with HTTP; Tue, 12 Feb 2013 04:45:45 -0800 (PST)
In-Reply-To: <CAFiYyc1RD88sGeA995Nds3ffkBmUWXVDBpAxW0pmeVUKhoO+8w@mail.gmail.com>
References: <511A35DC.7060207@ubuntu.com>	<CAFiYyc1RD88sGeA995Nds3ffkBmUWXVDBpAxW0pmeVUKhoO+8w@mail.gmail.com>
Date: Tue, 12 Feb 2013 12:46:00 -0000
Message-ID: <CAFiYyc1u5t9YKY5Pi_uZvej6xy4ihW_CvgsoR=MqPjKoZ6=9_A@mail.gmail.com>
Subject: Re: [patch] [libffi] do not install libffi library, headers and documentation
From: Richard Biener <richard.guenther@gmail.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, GCJ-patches <java-patches@gcc.gnu.org>, 	"libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2013-q1/txt/msg00014.txt.bz2

On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose <doko@ubuntu.com> wrote:
>> The libffi library, headers and documentation are still installed, although
>> libffi provides separate releases for a long time.  So do not install these
>> anymore as part of a GCC install.  Tested with a build and an install with go
>> and java enabled (both using libffi_convenience). Ok for the trunk?
>
> openSUSE is using the GCC provided libffi, so no, this is not ok (not at this
> stage anyway).  Also proper not-installing libffi would work by disabling
> the maybe-install-target-libffi at the toplevel, not changing libffi makfiles
> (which are supposed to be imported from upstream, no?)

Thus, add no_install= true; to the libffi target module

> Richard.
>
>>   Matthias
>>