From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23948 invoked by alias); 11 Aug 2011 19:53:35 -0000 Received: (qmail 23920 invoked by uid 22791); 11 Aug 2011 19:53:34 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Aug 2011 19:53:20 +0000 Received: by wyf19 with SMTP id 19so1950197wyf.20 for ; Thu, 11 Aug 2011 12:53:18 -0700 (PDT) Received: by 10.216.166.14 with SMTP id f14mr37806wel.10.1313092398102; Thu, 11 Aug 2011 12:53:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.229.163 with HTTP; Thu, 11 Aug 2011 12:52:58 -0700 (PDT) In-Reply-To: References: <4E42AACB.2080802@gnu.org> <4E42B494.9010309@gnu.org> From: Paolo Bonzini Date: Fri, 12 Aug 2011 07:28:00 -0000 Message-ID: Subject: Re: [build] Move unwinder to toplevel libgcc (v2) To: "H.J. Lu" Cc: Rainer Orth , "Joseph S. Myers" , gcc-patches@gcc.gnu.org, Ralf Wildenhues , Ian Lance Taylor , Steve Ellcey , Richard Earnshaw , Ramana Radhakrishnan , Nick Clifton , Douglas Rupp , Tristan Gingold , Mike Stump , Kaz Kojima , David Edelsohn , Sterling Augustine , Arnaud Charlet , java-patches@gcc.gnu.org, Nicola Pero , libstdc++@gcc.gnu.org, Richard Sandiford Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q3/txt/msg00067.txt.bz2 On Thu, Aug 11, 2011 at 20:19, H.J. Lu wrote: > On Thu, Aug 11, 2011 at 8:23 AM, Rainer Orth > wrote: >> Paolo Bonzini writes: >> >>> On 08/10/2011 06:05 PM, Rainer Orth wrote: >>>>>> >> =A0True: it is called once per multilib. >>>>> > >>>>> > =A0Just to doublecheck, are we sure that unwind.h is always the sam= e? >>>> Yep: it's unwind-generic.h for almost all targets, just a few arm >>>> targets use config/arm/unwind-arm.h for all multilibs. >>> >>> Patch doing rm -f is preapproved then. >> >> Here's what I installed, after making libgcc/unwind-generic.h read-only, >> reconfiguring and rebuilding first without and with the patch and >> observe the bug gone on i386-pc-solaris2.10. >> >> =A0 =A0 =A0 =A0Rainer >> >> >> 2011-08-11 =A0Rainer Orth =A0 >> >> =A0 =A0 =A0 =A0* Makefile.in (install-unwind_h): Remove destination file= first. >> >> diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in >> --- a/libgcc/Makefile.in >> +++ b/libgcc/Makefile.in >> @@ -994,6 +994,7 @@ gcc-extra-parts: >> =A0all: $(extra-parts) >> >> =A0install-unwind_h: >> + =A0 =A0 =A0 rm -f $(gcc_objdir)/include/unwind.h >> =A0 =A0 =A0 =A0cp unwind.h $(gcc_objdir)/include/unwind.h >> =A0 =A0 =A0 =A0chmod a+r $(gcc_objdir)/include/unwind.h >> > > It breaks bootstrap with "make -j12" on a 24 core Linux/x86-64 =A0: > > http://gcc.gnu.org/ml/gcc-regression/2011-08/msg00179.html > > rm -f ../../.././gcc/include/unwind.h > cp unwind.h ../../.././gcc/include/unwind.h > rm -f ../.././gcc/include/unwind.h > chmod a+r ../../.././gcc/include/unwind.h > cp unwind.h ../.././gcc/include/unwind.h > chmod: cannot access `../../.././gcc/include/unwind.h': No such file > or directory > make[8]: *** [install-unwind_h] Error 1 > make[8]: *** Waiting for unfinished jobs.... > chmod a+r ../.././gcc/include/unwind.h > > We may have a race condition here. Will take a look tomorrow. Paolo