From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44857 invoked by alias); 13 May 2015 16:26:06 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 44831 invoked by uid 89); 13 May 2015 16:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-yh0-f50.google.com Received: from mail-yh0-f50.google.com (HELO mail-yh0-f50.google.com) (209.85.213.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 13 May 2015 16:26:04 +0000 Received: by yhcb70 with SMTP id b70so15202383yhc.0 for ; Wed, 13 May 2015 09:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=yI4yTMpKDceCpnd+UzRDgkVuZho/8F5M3A8SiloH6WI=; b=iT/CHuvBO7BpKz6LmflWTP0GTpwx5uisD78lg/Zayx+rf7P2oMhmbRXKu6gnV93X6W I5Pbcu4dA0o4Pw6YPHdv8QW4GHOm/3O+1Cy91SZErBTzW4Jwu4w9eDqYyprEzMWgUTEj CpS2XULy6B4JZeXGAFA/fZlbRO0DNZJ3Abo6qW794GqlGr47DGDtONrMs4Uv3eMJqMXC HwyVYtXv27iJvDsBVOPMH3J/zsgf8CBbeT3pB+Duphl0SRqpo7V0fDufaXzYt4xtaX+8 C1E+O0aELZ/90vpRhNb3NF+zktpF7gt1ITOsMJDs25Fse097sxzKoJf9UD26f7w+H3oB FwDA== X-Gm-Message-State: ALoCoQk9rG5d3wr2XFfexSJmkGJOCf1GKzDquCI1CGncIGSc5xHToaYA08HeHY1aFR79eEKWVrwy MIME-Version: 1.0 X-Received: by 10.236.203.51 with SMTP id e39mr21001760yho.164.1431534362881; Wed, 13 May 2015 09:26:02 -0700 (PDT) Received: by 10.13.244.6 with HTTP; Wed, 13 May 2015 09:26:02 -0700 (PDT) In-Reply-To: <1440100.16fMh0Bpp2@polaris> References: <1440100.16fMh0Bpp2@polaris> Date: Wed, 13 May 2015 16:26:00 -0000 Message-ID: Subject: Re: [patch] Clean up detection of SJLJ exceptions in target libraries From: Ian Lance Taylor To: Eric Botcazou Cc: gcc-patches , "libstdc++@gcc.gnu.org" , GCJ-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-q2/txt/msg00016.txt.bz2 On Tue, May 12, 2015 at 9:42 AM, Eric Botcazou wrote: > > 6 target libraries in the tree detect whether they are being compiled by a > compiler configured for setjmp/longjmp exceptions: libada, libgcc, libgo, > libjava, libobjc and libstdc++. They can be divided into 3 categories: > 1) libada only checks the preprocessor macro __USING_SJLJ_EXCEPTIONS__, > 2) libgcc and libgo both check the preprocessor macro and implement a > configure check that defines another macro (LIBGCC_SJLJ_EXCEPTIONS and > LIBGO_SJLJ_EXCEPTIONS resp) so they'd better agree. > 3) libjava, libobjc and libstdc++ implement a configure check that defines a > macro (SJLJ_EXCEPTIONS, SJLJ_EXCEPTIONS and _GLIBCXX_SJLJ_EXCEPTIONS resp). > > The attached patch gets rid of the library-specific macros and replaces them > with __USING_SJLJ_EXCEPTIONS__. Moreover, it adds a config/sjlj.m4 fragment > that defines GCC_CHECK_SJLJ_EXCEPTIONS for libraries that need to detect the > exception model in the configure phase (libgcc and libjava only). > > Tested on x86_64-suse-linux with --enable-sjlj-exceptions. The results are > not clean (except for objc and obj-c++) but sufficient to see that exceptions > still work after the patch. OK for the mainline? The libgo parts are fine, but since libgo is mirrored from an external repository I'll commit those parts myself. I assume I can go ahead and commit them now? There is no reason to wait for the rest of the patch, is there? Ian