From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6287 invoked by alias); 26 Mar 2013 20:28:19 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 6250 invoked by uid 89); 26 Mar 2013 20:28:12 -0000 X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_BF autolearn=ham version=3.3.1 Received: from mail-oa0-f53.google.com (HELO mail-oa0-f53.google.com) (209.85.219.53) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 20:28:09 +0000 Received: by mail-oa0-f53.google.com with SMTP id m17so6750888oag.12 for ; Tue, 26 Mar 2013 13:28:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=h1iXJB/2W/ljgVB6h0brN394W54t0iWJmbExGTNcwyk=; b=Uv+Yp+PLAVBYirQCRdBLcOimTCK7o+qiAKqLrbhuayaFJfO0zyoeOqYWGoEzgJO6f0 blxvsSOj4ir+mCO8UjaQqO1FhNp1ZXjDpUQ7686dZqN8fLjLwre8pKSEntwD0w4wZEww 1dFjRyf+UdgKgTCm9VKNz4n8eJ4r2lYTuIWQ5l0FhBaL+4bcKM8yJArc7SP1R7lweVQt iH9hCPCvDPuz0MCBrLyHBpy1W9UYP8ZbdO9YLjmOZS3xeYUxhiTQpnpH0W5tXs1pSQ0T PxKfZaNKcmjHqwPE1O/JIr0j905h9YX/NTOZdKAzXXs9QF7x8gQbx15f7t+uxHnn964C 5KrA== MIME-Version: 1.0 X-Received: by 10.60.32.11 with SMTP id e11mr14513712oei.50.1364329688048; Tue, 26 Mar 2013 13:28:08 -0700 (PDT) Received: by 10.60.136.136 with HTTP; Tue, 26 Mar 2013 13:28:07 -0700 (PDT) In-Reply-To: <5151FF27.6040606@ubuntu.com> References: <511A35DC.7060207@ubuntu.com> <51225EBE.1050509@ubuntu.com> <5151FF27.6040606@ubuntu.com> Date: Tue, 26 Mar 2013 20:28:00 -0000 Message-ID: Subject: Re: [ping] Re: [patch] [libffi] do not install libffi library, headers and documentation From: Ian Lance Taylor To: Matthias Klose Cc: Andrew Haley , Tom Tromey , GCC Patches , GCJ-patches , "libffi-discuss@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQne9uLuBy40OUjnvAr1O0n/S8X0SFqzeG9oVlLDBU977EJZDrSakjds6AOgVx1pNaCzseiM16GdF8p83s/Jmx/oqm2n63FwhTLA2v4xaFLKUJzoD34q3Y2rnb/a9vFVxsTPrzX2z+dcEUTbnMth7Kzg8tpCopApyPm1wbbF8Q2XNVQ3TZ9n4g4RId+9MZ1dF4YulzXf X-SW-Source: 2013-q1/txt/msg00027.txt.bz2 On Tue, Mar 26, 2013 at 1:03 PM, Matthias Klose wrote: > [ping, adding the GCJ and Go maintainers] > > proposed patch at http://gcc.gnu.org/ml/gcc-patches/2013-02/msg00853.html As far as I know this won't affect Go. So it's fine with me. But I'd rather see this approved by a libffi maintainer. But there is no libffi maintainer listed in MAINTAINERS. Hmmm. Ian > Am 19.02.2013 10:13, schrieb Richard Biener: >> On Mon, Feb 18, 2013 at 6:02 PM, Matthias Klose wrote: >>> Am 12.02.2013 13:45, schrieb Richard Biener: >>>> On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener >>>> wrote: >>>>> On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose wrote: >>>>>> The libffi library, headers and documentation are still installed, although >>>>>> libffi provides separate releases for a long time. So do not install these >>>>>> anymore as part of a GCC install. Tested with a build and an install with go >>>>>> and java enabled (both using libffi_convenience). Ok for the trunk? >>>>> >>>>> openSUSE is using the GCC provided libffi, so no, this is not ok (not at this >>>>> stage anyway). Also proper not-installing libffi would work by disabling >>>>> the maybe-install-target-libffi at the toplevel, not changing libffi makfiles >>>>> (which are supposed to be imported from upstream, no?) >>>> >>>> Thus, add no_install= true; to the libffi target module >>> >>> updated patch attached, checked with a make install that no ffi headers and >>> libraries are installed. If not ok for 4.8, ok for 4.9 when it opens? >> >> I'm fine with that variant but I'd like to see another ok. No preference as to >> whether to target 4.8 or 4.9. >> >> Richard. >> >>> Matthias >>> >