public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bryce McKinlay <bmckinlay@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>,
	Java Patch List <java-patches@gcc.gnu.org>,
		GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix linking with -findirect-dispatch
Date: Tue, 16 Apr 2013 08:59:00 -0000	[thread overview]
Message-ID: <CALUNu-qUgdOt+Ut1_RsY2Yq4hcT-6eW4WzFbu_hYCX5j4FGGuA@mail.gmail.com> (raw)
In-Reply-To: <20130416083855.GM12880@tucnak.redhat.com>

On Tue, Apr 16, 2013 at 9:38 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Apr 16, 2013 at 10:35:29AM +0200, Andreas Schwab wrote:
>> Linking with -findirect-dispatch fails with this error:
>>
>> x86_64-linux-gcj -o ecjx -findirect-dispatch --main=org.eclipse.jdt.internal.compiler.batch.GCCMain ../../../gcc/libjava/../ecj.jar ecjx.o
>> /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: /tmp/ccppO92n.o: undefined reference to symbol '_Jv_MonitorExit'
>> /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: note: '_Jv_MonitorExit' is defined in DSO /usr/lib64/libgcj.so.13 so try adding it to the linker command line
>>
>> Andreas.
>>
>>       * configure.ac (LIBGCJ_SPEC_LGCJ_BC): Append -lgcj.
>>       (libgcj_spec_lgcj_bc_override): Likewise.
>>       * configure: Regenerate.
>
> That doesn't look right, if -findirect-dispatch now newly needs
> _Jv_MonitorExit (when has that been added?), then the symbol should
> be added to libgcj_bc.so.

That's right. -findirect-dispatch code should not link libgcj directly.

_Jv_MonitorExit has always been defined in libgcj_bc (see
libgcj_bc.c), so something else is going wrong here.

Bryce

  reply	other threads:[~2013-04-16  8:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16  8:36 Andreas Schwab
2013-04-16  8:39 ` Jakub Jelinek
2013-04-16  8:59   ` Bryce McKinlay [this message]
2013-04-16  9:13   ` Andreas Schwab
2013-04-16  9:19     ` Jakub Jelinek
2013-04-16  9:37       ` Andreas Schwab
2013-04-16  9:49         ` Jakub Jelinek
2013-04-16  9:55           ` Matthias Klose
2013-04-26 11:22             ` Matthias Klose
2013-04-26 11:50               ` Andrew Haley
2013-04-16  9:57           ` Andreas Schwab
2013-04-16 10:08             ` Jakub Jelinek
2013-04-16 10:11               ` Andreas Schwab
2013-04-16 10:26                 ` Jakub Jelinek
2013-04-16 10:31                   ` Andreas Schwab
2013-04-16 16:13                   ` Andreas Schwab
2013-04-16 16:19                     ` Jakub Jelinek
2013-04-16 17:22                       ` Andreas Schwab
2013-06-03 10:56                       ` Andreas Schwab
2013-04-16 16:39                     ` Bryce McKinlay
2013-04-17 13:17                       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALUNu-qUgdOt+Ut1_RsY2Yq4hcT-6eW4WzFbu_hYCX5j4FGGuA@mail.gmail.com \
    --to=bmckinlay@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=java-patches@gcc.gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).