From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 333 invoked by alias); 18 Jul 2012 17:58:54 -0000 Received: (qmail 315 invoked by uid 22791); 18 Jul 2012 17:58:52 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 17:58:39 +0000 Received: by vcbfy27 with SMTP id fy27so1442931vcb.20 for ; Wed, 18 Jul 2012 10:58:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.176.232 with SMTP id cl8mr1127591vdc.115.1342634318299; Wed, 18 Jul 2012 10:58:38 -0700 (PDT) Received: by 10.58.74.198 with HTTP; Wed, 18 Jul 2012 10:58:38 -0700 (PDT) In-Reply-To: References: <20120716210441.GA5620@intel.com> <20120718163007.GA23495@intel.com> <5006F3AD.5000601@redhat.com> Date: Wed, 18 Jul 2012 17:58:00 -0000 Message-ID: Subject: Re: PR libjava/53973: Check and and skip 67h address size prefix for x32 From: "H.J. Lu" To: Uros Bizjak Cc: Andrew Haley , "H.J. Lu" , java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2012-q3/txt/msg00009.txt.bz2 On Wed, Jul 18, 2012 at 10:47 AM, Uros Bizjak wrote: > On Wed, Jul 18, 2012 at 7:34 PM, Andrew Haley wrote: >> On 07/18/2012 05:30 PM, H.J. Lu wrote: >>> 2012-07-16 H.J. Lu >>> >>> PR libjava/53973 >>> * include/x86_64-signal.h (CHECK_67H_PREFIX): New. >>> (HANDLE_DIVIDE_OVERFLOW): Check and and skip 67h address size >>> prefix if CHECK_67H_PREFIX is 1. Use ULL suffix for 64-bit >>> integer. >> >> OK. I would have thought it was OK to skip the 67h address size >> whether or not it was x32, though. > > You can just skip the prefix unconditionally. > > Uros. I will check in this patch shortly. Thanks. -- H.J. --- 2012-07-18 H.J. Lu PR libjava/53973 * include/x86_64-signal.h (CHECK_67H_PREFIX): Removed. (HANDLE_DIVIDE_OVERFLOW): Check and and skip 67h address size prefix unconditionally. diff --git a/libjava/include/x86_64-signal.h b/libjava/include/x86_64-signal.h index 84907c3..aa5a903 100644 --- a/libjava/include/x86_64-signal.h +++ b/libjava/include/x86_64-signal.h @@ -21,12 +21,6 @@ details. */ #define HANDLE_SEGV 1 #define HANDLE_FPE 1 -#ifdef __ILP32__ -# define CHECK_67H_PREFIX 1 -#else -# define CHECK_67H_PREFIX 0 -#endif - #define SIGNAL_HANDLER(_name) \ static void _Jv_##_name (int, siginfo_t *, \ void *_p __attribute__ ((__unused__))) @@ -53,8 +47,8 @@ do \ \ bool _is_64_bit = false; \ \ - /* Check and skip 67h address size prefix if needed. */ \ - if (CHECK_67H_PREFIX && _rip[0] == 0x67) \ + /* Check and skip 67h address size prefix. */ \ + if (_rip[0] == 0x67) \ _rip++; \ \