From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12146 invoked by alias); 1 Oct 2006 18:00:18 -0000 Received: (qmail 12137 invoked by uid 22791); 1 Oct 2006 18:00:17 -0000 X-Spam-Check-By: sourceware.org Received: from ms-smtp-04.rdc-kc.rr.com (HELO ms-smtp-04.rdc-kc.rr.com) (24.94.166.116) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 01 Oct 2006 18:00:14 +0000 Received: from d9300 (CPE-65-30-191-92.wi.res.rr.com [65.30.191.92]) by ms-smtp-04.rdc-kc.rr.com (8.13.6/8.13.6) with SMTP id k91I0Asg028022; Sun, 1 Oct 2006 13:00:12 -0500 (CDT) From: Mohan Embar To: Marco Trudel Cc: Gary Benson , java-patches@gcc.gnu.org Date: Sun, 01 Oct 2006 18:00:00 -0000 Reply-To: gnustuff@thisiscool.com In-Reply-To: <451FFC83.8030105@gmx.ch> Message-Id: Subject: Re: RFC: Untested Win32 InetAddress tweak MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Opera 6.05 build 1140 X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q4/txt/msg00004.txt.bz2 Hi All, >> The last part of java.net.InetAddress.lookup (a native method) is the >> same in both Posix and Win32 variants except for a security check that >> was removed from the Posix variant in August 2004. The attached patch >> removes this check from the Win32, synchronising the two. >> >> I don't have the ability to test this, so could someone try it for me? >> Alternatively, is this a trivial enough change to just commit blind? > >Something must have went wrong. java/net/InetAddress.java was changed >according this patch, java/net/natInetAddressWin32.cc has not. This >leads to an error on compilation. Please commit the rest as well... > >Here's the link to the trunk head, you can see that the code is still there: >http://gcc.gnu.org/viewcvs/trunk/libjava/java/net/natInetAddressWin32.cc?view=markup I agree with Marco. Although I understand that Gary probably can't commit the rest without approval, I can also confirm that current SVN HEAD breaks for Win32 without Gary's patch + my minor address-of corrections. -- Mohan http://www.thisiscool.com/ http://www.animalsong.org/