From: Gerald Pfeifer <gerald@pfeifer.com>
To: Tom Tromey <tromey@redhat.com>, David Daney <ddaney@avtrex.com>
Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libjava: Add option to disable BC ABI in libgcj.
Date: Sun, 30 Dec 2007 14:31:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0712301502360.25278@acrux.dbai.tuwien.ac.at> (raw)
In-Reply-To: <476C3D6A.6060704@avtrex.com>
On Fri, 21 Dec 2007, Tom Tromey wrote:
> I don't think I can approve the install.texi change.
Sure you can. ;-) (Certainly for or those areas where you are a
maintainer or otherwise authoritative.)
On Fri, 21 Dec 2007, David Daney wrote:
> * doc/install.texi (disable-libgcj-bc): Document new option.
+@item --disable-libgcj-bc
+Disable BC ABI compilation of certain parts of libgcj. By default,
+some portions of libgcj are compiled with @option{-findirect-dispatch}
+@option{-fno-indirect-classes}. This allows them to be overridden at
+runtime.
When first reading this, I got a bit confused by two aspects. Perhaps
this is something to address in a follow-up patch, David?
One was that "BC API compilation" (including myself ;-) isn't something
most readers of doc/install.texi would be familiar with. How about
expanding this or adding a reference/cross-reference?
The second one was that I wasn't sure what "This" referred to: the
configure option, or the previous sentence explaining BC ABI compilation.
Perhaps replacing this by ", which" might be more clear?
+If @option{--disable-libgcj-bc} is specified, libgcj is built without
+these options. This makes it impossible to override portions of
+libgcj at runtime, but can make it easier to statically link to libgcj.
Why does this read "can make" and not just "makes"? I'm sure there is
some technical background here which I'm missing. :-) Perhaps a (cross)
reference to more detailed information somewhere else could clarify that?
Gerald
next prev parent reply other threads:[~2007-12-30 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 22:25 David Daney
2007-12-21 23:40 ` Tom Tromey
2007-12-22 11:19 ` Andrew Haley
2007-12-30 14:31 ` Gerald Pfeifer [this message]
2008-01-26 5:18 ` David Daney
2008-01-26 10:51 ` Andrew Haley
2008-01-26 21:50 ` David Daney
2008-01-27 10:34 ` Andrew Haley
2008-01-28 0:09 ` Gerald Pfeifer
2008-01-28 4:38 ` David Daney
2008-01-28 10:23 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712301502360.25278@acrux.dbai.tuwien.ac.at \
--to=gerald@pfeifer.com \
--cc=ddaney@avtrex.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).