From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9239 invoked by alias); 22 Apr 2009 22:10:56 -0000 Received: (qmail 9204 invoked by uid 22791); 22 Apr 2009 22:10:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from mx20.gnu.org (HELO mx20.gnu.org) (199.232.41.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 22:10:48 +0000 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LwkeP-00024P-TK for java-patches@gcc.gnu.org; Wed, 22 Apr 2009 18:10:42 -0400 Received: (qmail 4116 invoked from network); 22 Apr 2009 21:43:58 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Apr 2009 21:43:58 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1LwkEL-000649-H8; Wed, 22 Apr 2009 21:43:45 +0000 Date: Wed, 22 Apr 2009 22:10:00 -0000 From: "Joseph S. Myers" To: Ian Lance Taylor cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: PATCH RFA: -Wc++-compat warnings for assignments to enum variables In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2009-q2/txt/msg00026.txt.bz2 On Wed, 22 Apr 2009, Ian Lance Taylor wrote: > There are two patches here. The first, smaller, patch enables the > warning. The main work here is to add a parameter to build_modify_expr, > so that we can emit warnings for assignments to bitfields in structs > with enum type. The additional parameter is required because at the > point of convert_for_assignment, the original enum type has been > replaced by a bitfield integer type. This patch requires approval from > the C and C++ frontend maintainers. Please also take a quick look at > the new test case, and let me know if there are any other cases I should > check. The C changes are OK. -- Joseph S. Myers joseph@codesourcery.com