From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28741 invoked by alias); 20 Jun 2011 15:11:18 -0000 Received: (qmail 28719 invoked by uid 22791); 20 Jun 2011 15:11:17 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_05,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jun 2011 15:11:03 +0000 Received: (qmail 32136 invoked from network); 20 Jun 2011 15:11:02 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Jun 2011 15:11:02 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QYg7w-0004WP-QD; Mon, 20 Jun 2011 15:11:00 +0000 Date: Mon, 20 Jun 2011 15:11:00 -0000 From: "Joseph S. Myers" To: Rainer Orth cc: gcc-patches@gcc.gnu.org, Paolo Bonzini , Ralf Wildenhues , Ian Lance Taylor , Steve Ellcey , Richard Earnshaw , Ramana Radhakrishnan , Nick Clifton , Douglas Rupp , Tristan Gingold , Mike Stump , Kaz Kojima , David Edelsohn , Sterling Augustine , Arnaud Charlet , java-patches@gcc.gnu.org, Nicola Pero , libstdc++@gcc.gnu.org, Richard Sandiford Subject: Re: [build] Move unwinder to toplevel libgcc In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q2/txt/msg00080.txt.bz2 On Mon, 20 Jun 2011, Rainer Orth wrote: > * Move all remaining unwinder-only macros to libgcc: UNW_IVMS_MODE, > MD_UNW_COMPATIBLE_PERSONALITY_P, MD_FROB_UPDATE_CONTEXT. I don't see any sign of macros being poisoned in system.h. For macros used in target-independent unwinder code - at least MD_FROB_UPDATE_CONTEXT - that used to be defined in the host tm.h but now no longer should be, I think poisoning in system.h is appropriate. > * The only unwinder-related macro I haven't moved is > LIBGCC2_UNWIND_ATTRIBUTE. It is only defined gcc/config/mips/mips.h. > I suppose we would need a libgcc equivalent of tm.h for that, > something I didn't want to attack at this point. What about DWARF_ZERO_REG and PRE_GCC3_DWARF_FRAME_REGISTERS? DWARF_REG_TO_UNWIND_COLUMN may be more complicated because it's used on the host in rs6000.c (although not in target-independent host code) as well as on the target - I suspect that will be a case where duplicating the definition (with a comment in one place pointing to the other place as needing to be kept consistent, and with the host-side copy renamed to facilitate poisoning) may make sense. And all three are defined in .h headers so your reason for moving them separately may apply. (There are lots more macros used in the unwinder and on the host for which macros predefined with -fbuilding-libgcc may be appropriate in a later patch.) -- Joseph S. Myers joseph@codesourcery.com