From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8488 invoked by alias); 9 Aug 2011 17:33:12 -0000 Received: (qmail 8471 invoked by uid 22791); 9 Aug 2011 17:33:12 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 17:32:59 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p79HWwPA009775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Aug 2011 13:32:58 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p79HWwGM029375; Tue, 9 Aug 2011 13:32:58 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p79HWueX004812; Tue, 9 Aug 2011 13:32:57 -0400 From: Tom Tromey To: Jie Liu Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org, Joel Sherrill Subject: Re: [PATCH] [JAVA] Double.parseDouble(null) throw NullPointerException References: Date: Wed, 10 Aug 2011 13:34:00 -0000 In-Reply-To: (Jie Liu's message of "Wed, 10 Aug 2011 00:41:22 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q3/txt/msg00046.txt.bz2 >>>>> "Jie" == Jie Liu writes: Jie> RTEMS does not have virtual memory management, so there is no error Jie> when access the 0 address on rtems. Jie> So 'str->length()' donot throw NPE and just return an meaningless value. If you compile the Java parts of the library with -fcheck-references, it should work. This is something you have to set up as part of the port, as it is decided at (libgcj-) configure time. This won't help with the native code. IIRC in the end we just gave up on that; if you wanted real correctness you would have to add a null check at every dereference in the C++ code. I believe Andrew had a g++ patch to do this in the compiler, but it was rejected. Tom