public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Patch: fix alsa configury for systems with multilibs
@ 2005-12-01 16:59 Anthony Green
  2005-12-01 19:19 ` [cp-patches] " Mark Wielaard
  2005-12-02 19:43 ` Tom Tromey
  0 siblings, 2 replies; 3+ messages in thread
From: Anthony Green @ 2005-12-01 16:59 UTC (permalink / raw)
  To: classpath-patches, java-patches

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

It's not enough to test that the alsa headers exist.  We also need to
make sure the libraries are there.  This was a problem for x86-64 linux.

Ok for everywhere?

AG



[-- Attachment #2: alsa.patch --]
[-- Type: text/x-patch, Size: 911 bytes --]

2005-12-01  Anthony Green  <green@redhat.com>

	* configure.ac: Make sure we have an alsa library in addition to
	the headers.  This extra test is required for systems with
	multilibs.
	* configure: Rebuilt.


Index: libjava/classpath/configure.ac
===================================================================
--- libjava/classpath/configure.ac	(revision 107822)
+++ libjava/classpath/configure.ac	(working copy)
@@ -112,7 +112,9 @@
                 no) COMPILE_ALSA=no ;;
                 *) COMPILE_ALSA=yes ;;
               esac],
-	      [AC_CHECK_HEADERS([alsa/asoundlib.h],COMPILE_ALSA=yes,COMPILE_ALSA=no)])
+	      [AC_CHECK_HEADERS([alsa/asoundlib.h],
+				[AC_CHECK_LIB([asound], [snd_seq_open], COMPILE_ALSA=yes,COMPILE_ALSA=no)],
+				COMPILE_ALSA=no)])
 AM_CONDITIONAL(CREATE_ALSA_LIBRARIES, test "x${COMPILE_ALSA}" = xyes)
 
 dnl -----------------------------------------------------------

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [cp-patches] Patch: fix alsa configury for systems with  multilibs
  2005-12-01 16:59 Patch: fix alsa configury for systems with multilibs Anthony Green
@ 2005-12-01 19:19 ` Mark Wielaard
  2005-12-02 19:43 ` Tom Tromey
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2005-12-01 19:19 UTC (permalink / raw)
  To: Anthony Green; +Cc: classpath-patches, java-patches

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi Anthony,

On Thu, 2005-12-01 at 08:59 -0800, Anthony Green wrote:
> It's not enough to test that the alsa headers exist.  We also need to
> make sure the libraries are there.
>
> 2005-12-01  Anthony Green  <green@redhat.com>
>
>        * configure.ac: Make sure we have an alsa library in addition to
>        the headers.  This extra test is required for systems with
>        multilibs.
>        * configure: Rebuilt.
>
> Ok for everywhere?

Looks fine to me. (Note that configure isn't in CVS for classpath.)

Thanks,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch: fix alsa configury for systems with multilibs
  2005-12-01 16:59 Patch: fix alsa configury for systems with multilibs Anthony Green
  2005-12-01 19:19 ` [cp-patches] " Mark Wielaard
@ 2005-12-02 19:43 ` Tom Tromey
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2005-12-02 19:43 UTC (permalink / raw)
  To: Anthony Green; +Cc: classpath-patches, java-patches

>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

Anthony> It's not enough to test that the alsa headers exist.  We also
Anthony> need to make sure the libraries are there.  This was a
Anthony> problem for x86-64 linux.
Anthony> Ok for everywhere?

We talked on irc, but just for the record -- yes please, especially
the 4.1 branch.

Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-12-02 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-01 16:59 Patch: fix alsa configury for systems with multilibs Anthony Green
2005-12-01 19:19 ` [cp-patches] " Mark Wielaard
2005-12-02 19:43 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).