From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20289 invoked by alias); 24 May 2006 00:39:45 -0000 Received: (qmail 20273 invoked by uid 22791); 24 May 2006 00:39:44 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 May 2006 00:39:42 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k4O0de1W004081; Tue, 23 May 2006 20:39:40 -0400 Received: from opsy.redhat.com (vpn50-112.rdu.redhat.com [172.16.50.112]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k4O0ddF7026325; Tue, 23 May 2006 20:39:39 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 689794E439C; Tue, 23 May 2006 18:36:16 -0600 (MDT) To: Andreas Tobler Cc: Java Patches , John David Anglin Subject: Re: [patch] include/posix.h References: <446E43A3.3080507@pop.agri.ch> <447366D3.5030905@pop.agri.ch> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Wed, 24 May 2006 00:39:00 -0000 In-Reply-To: <447366D3.5030905@pop.agri.ch> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q2/txt/msg00226.txt.bz2 >>>>> "Andreas" == Andreas Tobler writes: Andreas> Well, this does not help if Boolean.h is included before such magic Andreas> system headers which define TRUE and FALSE again. Yeah. However, any ordering will have an associated potential failure mode, afaics. Andreas> In our case sys/rw_lock.h, the file where this (re)-definition Andreas> happens, is included after Boolean.h, implicitely. So I tend to agree Andreas> with Dave that the workaround he proposes is probably the best one in Andreas> regard of effort and gain. That patch also looked fine to me. Feel free to check it in. Tom