From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17554 invoked by alias); 18 Jan 2008 19:46:53 -0000 Received: (qmail 17539 invoked by uid 22791); 18 Jan 2008 19:46:53 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 Jan 2008 19:46:35 +0000 Received: from zps38.corp.google.com (zps38.corp.google.com [172.25.146.38]) by smtp-out.google.com with ESMTP id m0IJjscv006607; Fri, 18 Jan 2008 19:45:55 GMT Received: from localhost.localdomain.google.com (dhcp-172-18-116-196.corp.google.com [172.18.116.196]) (authenticated bits=0) by zps38.corp.google.com with ESMTP id m0IJjrXO024248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 18 Jan 2008 11:45:53 -0800 To: David Daney Cc: gcc-patches , binutils@sourceware.org, Java Patch List Subject: Re: [Patch 1/2] Add demangling for java resource files to libiberty References: <478C061B.1040003@avtrex.com> From: Ian Lance Taylor Date: Fri, 18 Jan 2008 19:46:00 -0000 In-Reply-To: <478C061B.1040003@avtrex.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2008-q1/txt/msg00017.txt.bz2 David Daney writes: > 2008-01-14 David Daney > > * demangle.h (demangle_component_type): Add > DEMANGLE_COMPONENT_JAVA_RESOURCE, > DEMANGLE_COMPONENT_COMPOUND_NAME, and > DEMANGLE_COMPONENT_CHARACTER as new enum values. > (demangle_component): Add struct s_character to union u. > > libiberty/ > 2008-01-14 David Daney > > * cp-demangle.c (d_dump): Handle DEMANGLE_COMPONENT_JAVA_RESOURCE, > DEMANGLE_COMPONENT_COMPOUND_NAME, and > DEMANGLE_COMPONENT_CHARACTER cases. > (d_make_comp): Handle DEMANGLE_COMPONENT_COMPOUND_NAME and > DEMANGLE_COMPONENT_JAVA_RESOURCE cases. > (d_make_character): New function. > (d_java_resource_part): Same. > (d_java_resource): Same. > (d_special_name): Handle "Gr" case. > (d_print_comp): Handle DEMANGLE_COMPONENT_JAVA_RESOURCE, > DEMANGLE_COMPONENT_COMPOUND_NAME, and > DEMANGLE_COMPONENT_CHARACTER cases. > (testsuite/demangle-expected): Add test for java resource name > mangling. This patch is OK. It is OK for gcc 4.3 if the other part of the patch (to libjava) is committed to gcc 4.3. Otherwise please wait until after the 4.3 release branch is made. > + while (d_peek_char(di)) Please add a space before the left parenthesis. Thanks. Ian