PR java/24127: ICE in libjava.compile/PR6865.java

PR java/24127: ICE in libjava.compile/PR6865.java

[Ranjit Mathew]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

  Here is a simple fix for the ICE reported in PR24127 while
compiling the testcase for PR6865. The fix is to make the result
of the rule a NULL_TREE when an error occurs.

Tested on i686-pc-linux-gnu, Jacks included. No changes.
Verified manually that the testcase doesn't cause the compiler
to ICE any more.

OK for mainline?

Thanks,
Ranjit.

- --
Ranjit Mathew      Email: rmathew AT gmail DOT com

Bangalore, INDIA.    Web: http://ranjitmathew.hostingzero.com/


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDPPB8Yb1hx2wRS48RAm1yAJ97zXU3R8fi3Fkj3Y/gpF5eA1FeSwCfYtFC
4cCoSuQkbmb5/uEqbWchRMw=
=7FVi
-----END PGP SIGNATURE-----

[-- Attachment #2: pr24127.txt --]
[-- Type: text/plain, Size: 1012 bytes --]

Index: ChangeLog
from  Ranjit Mathew  <rmathew@gcc.gnu.org>

	PR java/24127
	* parse.y (method_header): Make the result of the rule a NULL_TREE
	when a parsing error occurs.

Index: parse.y
===================================================================
--- parse.y	2005-09-30 12:33:46.000000000 +0530
+++ parse.y	2005-09-30 12:34:43.000000000 +0530
@@ -1035,4 +1035,5 @@ method_header:
 		{
 		  yyerror ("Invalid method declaration, method name required");
+		  $$ = NULL_TREE;
 		  RECOVER;
 		}
@@ -1040,4 +1041,5 @@ method_header:
 		{
 		  yyerror ("Identifier expected");
+		  $$ = NULL_TREE;
 		  RECOVER;
 		}
@@ -1045,4 +1047,5 @@ method_header:
 		{
 		  yyerror ("Identifier expected");
+		  $$ = NULL_TREE;
 		  RECOVER;
 		}
@@ -1050,4 +1053,5 @@ method_header:
 		{
 		  yyerror ("Identifier expected");
+		  $$ = NULL_TREE;
 		  RECOVER;
 		}
@@ -1055,4 +1059,5 @@ method_header:
 		{
 		  yyerror ("Invalid method declaration, return type required");
+		  $$ = NULL_TREE;
 		  RECOVER;
 		}

Re: PR java/24127: ICE in libjava.compile/PR6865.java

[Tom Tromey]

>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:

Ranjit> Index: ChangeLog
Ranjit> from  Ranjit Mathew  <rmathew@gcc.gnu.org>
Ranjit> PR java/24127
Ranjit> * parse.y (method_header): Make the result of the rule a NULL_TREE
Ranjit> when a parsing error occurs.

This is ok.  Thanks.

Tom