From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8432 invoked by alias); 23 Apr 2009 01:05:17 -0000 Received: (qmail 8341 invoked by uid 22791); 23 Apr 2009 01:05:17 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Apr 2009 01:05:10 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3N152ks030988; Wed, 22 Apr 2009 21:05:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3N1515k003745; Wed, 22 Apr 2009 21:05:01 -0400 Received: from opsy.redhat.com (vpn-14-158.rdu.redhat.com [10.11.14.158]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3N150It029909; Wed, 22 Apr 2009 21:05:00 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8F9CD888034; Wed, 22 Apr 2009 19:04:59 -0600 (MDT) To: Dave Korn Cc: java-patches@gcc.gnu.org Subject: Re: [RFC] Fix PR38892: "--enable-libgcj-debug" breaks bootstrap. References: <49EF6F29.2000601@gmail.com> <49EFA476.5080305@gmail.com> From: Tom Tromey Reply-To: Tom Tromey Date: Thu, 23 Apr 2009 01:05:00 -0000 In-Reply-To: <49EFA476.5080305@gmail.com> (Dave Korn's message of "Thu\, 23 Apr 2009 00\:12\:54 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2009-q2/txt/msg00033.txt.bz2 >>>>> "Dave" == Dave Korn writes: Tom> Yeah, just GCJ_DEBUG would be fine. Dave> Do you care about the "__" prefix? I wasn't sure if maybe it Dave> might end up in the user's namespace (do any of the Dave> libjava/include files end up getting installed?), so I already Dave> did it the "__GCJ_DEBUG" way; I'll respin it if it matters. A couple of the headers are installed, but this symbol isn't used by any of them. So, without the underscores is ok. It doesn't matter hugely to me, though, so if you already have the patch, the underscore variant is fine too. Tom