From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28601 invoked by alias); 15 Feb 2007 22:13:28 -0000 Received: (qmail 28578 invoked by uid 22791); 15 Feb 2007 22:13:26 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 Feb 2007 22:13:22 +0000 Received: from zps36.corp.google.com (zps36.corp.google.com [172.25.146.36]) by smtp-out.google.com with ESMTP id l1FMDHM9027484; Thu, 15 Feb 2007 14:13:17 -0800 Received: from localhost.localdomain.google.com (dhcp-172-18-118-195.corp.google.com [172.18.118.195]) (authenticated bits=0) by zps36.corp.google.com with ESMTP id l1FMD6a5031233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 15 Feb 2007 14:13:06 -0800 To: Sandra Loosemore Cc: GCC Patches , java-patches@gcc.gnu.org, Brooks Moses , Lee Millward Subject: Re: revised PATCH: CALL_EXPR representation changes, part 7/9 (Java front end) References: <45D34BAA.8030408@codesourcery.com> From: Ian Lance Taylor Date: Thu, 15 Feb 2007 22:13:00 -0000 In-Reply-To: <45D34BAA.8030408@codesourcery.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2007-q1/txt/msg00506.txt.bz2 Sandra Loosemore writes: > 2007-02-14 Sandra Loosemore > Brooks Moses > Lee Millward > > * java-tree.h (BUILD_MONITOR_ENTER): Use build_call_nary instead > of build3. > (BUILD_MONITOR_EXIT): Likewise. > > * java-gimplify.c (java_gimplify_component_ref): Use build_call_expr. > (java_gimplify_modify_expr): Likewise. > > * class.c (cache_this_class_ref): Use build_call_expr. > (build_static_field_ref): Likewise. > (emit_indirect_register_classes): Likewise. > (emit_register_classes): Likewise. > > * resource.c (write_resource_constructor): Use build_call_expr. > > * builtins.c (builtin_creator_function): Change interpretation of > the second parameter to be the whole CALL_EXPR instead of the arglist. > (max_builtin): Tweak parameter list. Use new CALL_EXPR accessors. > (min_builtin): Likewise. > (abs_builtin): Likewise. > (java_build_function_call_expr): Likewise. > (convert_real): Likewise. > (UNMARSHAL3): Likewise. > (UNMARSHAL4): Likewise. > (UNMARSHAL5): Likewise. > (build_arglist_for_builtin): Delete. Fix callers to use > build_call_expr instead. > (putObject_builtin): Tweak parameter list. Use new CALL_EXPR > accessors. > (compareAndSwapInt_builtin): Likewise. > (compareAndSwapLong_builtin): Likewise. > (compareAndSwapObject_builtin): Likewise. > (putVolatile_builtin): Likewise. > (getVolatile_builtin): Likewise. > (VMSupportsCS8_builtin): Likewise. > (check_for_builtin): Pass entire CALL_EXPR to builtin expander > instead of arglist. > > * expr.c (build_java_athrow): Use build_call_nary instead of build3. > (build_java_throw_out_of_bounds_exception): Likewise. > (java_check_reference): Likewise. > (build_java_arraystore_check): Likewise. > (build_newarray): Likewise. > (build_anewarray): Likewise. > (expand_java_multinewarray): Use build_call_list instead of build3. > (build_java_monitor): Use build_call_nary instead of build3. > (java_create_object): Likewise. > (expand_java_NEW): Likewise. > (build_instanceof): Likewise. > (expand_java_CHECKCAST): Likewise. > (build_java_soft_divmod): Likewise. > (build_java_binop): Likewise. > (build_field_ref): Likewise. > (build_class_init): Likewise. > (rewrite_arglist_getcaller): Use build_call_expr. > (build_invokeinterface): Use build_call_nary instead of build3. > (expand_invoke): Use build_call_list instead of build3. > (build_jni_stub): Use build_call_nary, build_call_list, or > build_call_expr instead of build3. > (expand_java_field_op): Use build_call_expr instead of build3. > (force_evaluation_order): Use new CALL_EXPR accessors. > > * lang.c (java_get_callee_fndecl): Use new CALL_EXPR accessors. I can't technically approve this patch, but I looked through it and it looks OK to me. Ian