Patch: fix LogManager permission check

Patch: fix LogManager permission check

[Anthony Green]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

I hit PR classpath/28070 again today (in FC5).  I'd like to check this
patch into GNU Classpath, as well as GCC HEAD and the 4.1 branch.  Ok?

AG


[-- Attachment #2: lm.patch --]
[-- Type: text/x-patch, Size: 1324 bytes --]

2006-10-06  Anthony Green  <green@redhat.com>

	PR classpath/28070:
	* java/util/logging/LogManager.java: Don't share a control
	permission object.


Index: java/util/logging/LogManager.java
===================================================================
RCS file: /sources/classpath/classpath/java/util/logging/LogManager.java,v
retrieving revision 1.24
diff -u -r1.24 LogManager.java
--- java/util/logging/LogManager.java	19 Sep 2006 10:41:45 -0000	1.24
+++ java/util/logging/LogManager.java	6 Oct 2006 15:02:49 -0000
@@ -787,13 +787,6 @@
   }
 
   /**
-   * An instance of <code>LoggingPermission("control")</code>
-   * that is shared between calls to <code>checkAccess()</code>.
-   */
-  private static final LoggingPermission controlPermission = new LoggingPermission("control",
-                                                                                   null);
-
-  /**
    * Checks whether the current security context allows changing
    * the configuration of the logging framework.  For the security
    * context to be trusted, it has to be granted
@@ -807,7 +800,10 @@
   {
     SecurityManager sm = System.getSecurityManager();
     if (sm != null)
-      sm.checkPermission(controlPermission);
+      {
+	sm.checkPermission(new LoggingPermission("control",
+						 null));
+      }
   }
 
   /**

Re: Patch: fix LogManager permission check

[Anthony Green]

On Fri, 2006-10-06 at 08:07 -0700, Anthony Green wrote:
> I hit PR classpath/28070 again today (in FC5).  I'd like to check this
> patch into GNU Classpath, as well as GCC HEAD and the 4.1 branch.  Ok?
> 
> AG
> 

Ooops.  This is a GCC 4.1 only bug.  I withdraw my patch for GNU
Classpath.  Still Ok for GCC 4.1 branch?

AG

Re: Patch: fix LogManager permission check

[Tom Tromey]

>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

Anthony> Ooops.  This is a GCC 4.1 only bug.  I withdraw my patch for GNU
Anthony> Classpath.  Still Ok for GCC 4.1 branch?

Yes.

Note that this doesn't appear on the RH 4.1 branch either.  FWIW.

Tom

Re: Patch: fix LogManager permission check

[Anthony Green]

(I've removed classpath-patches from copy)

On Fri, 2006-10-06 at 09:38 -0600, Tom Tromey wrote:
> 
> 
> Note that this doesn't appear on the RH 4.1 branch either.  FWIW.

You mean the static section isn't there?  Was this changed recently?
The source in the gcc-debuginfo package for FC5 shows a static section
in LogManager.

AG

Re: Patch: fix LogManager permission check

[Tom Tromey]

Anthony> You mean the static section isn't there?  Was this changed
Anthony> recently?

We did a big backport not too long ago, I don't remember looking at
this file specifically.  But I think it did.

Anthony> The source in the gcc-debuginfo package for FC5 shows a
Anthony> static section in LogManager.

The RH 4.1 branch is FC6 now.

Tom