From: Tom Tromey <tromey@redhat.com>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: java-patches@gcc.gnu.org
Subject: Re: [RFC] Fix PR38892: "--enable-libgcj-debug" breaks bootstrap.
Date: Wed, 22 Apr 2009 22:51:00 -0000 [thread overview]
Message-ID: <m3prf4ti8i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <49EF6F29.2000601@gmail.com> (Dave Korn's message of "Wed\, 22 Apr 2009 20\:25\:29 +0100")
>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
Dave> 32 static jboolean DEBUG;
Dave> ... you can probably guess immediately what went wrong:
Whoops.
Dave> One solution that occurred to me was to rename the
Dave> preprocesser macro to (e.g.) "__GCJ_DEBUG" throughout.
Yeah, just GCJ_DEBUG would be fine.
Dave> Another solution that occurred to me was to rename the java
Dave> class members to (e.g.) "JDEBUG" throughout.
This is more of a pain since it means putting the patch in Classpath
as well. I think it should be simpler to just change the libgcj
native code.
Tom
next prev parent reply other threads:[~2009-04-22 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 19:14 Dave Korn
2009-04-22 22:51 ` Tom Tromey [this message]
2009-04-22 22:53 ` Dave Korn
2009-04-22 23:02 ` Dave Korn
2009-04-23 1:05 ` Tom Tromey
2009-04-23 2:33 ` Dave Korn
2009-04-26 0:18 ` Tom Tromey
2009-04-26 1:00 ` Dave Korn
2009-04-27 12:22 ` Dave Korn
2009-04-27 22:12 ` Tom Tromey
2009-04-28 4:04 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3prf4ti8i.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dave.korn.cygwin@googlemail.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).