From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11704 invoked by alias); 5 Mar 2007 13:35:28 -0000 Received: (qmail 11629 invoked by uid 22791); 5 Mar 2007 13:35:27 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Mar 2007 13:35:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l25DZMXI017103 for ; Mon, 5 Mar 2007 08:35:22 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l25DZLp0011853; Mon, 5 Mar 2007 08:35:21 -0500 Received: from opsy.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l25DZJPj009277; Mon, 5 Mar 2007 08:35:19 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 8FF7B3787C8; Mon, 5 Mar 2007 06:22:07 -0700 (MST) To: Kyle Galloway Cc: java-patches@gcc.gnu.org Subject: Re: [RFA] JDWP VMMethod::getVariableTable References: <45DDDDCF.1050802@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Mon, 05 Mar 2007 13:35:00 -0000 In-Reply-To: <45DDDDCF.1050802@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2007-q1/txt/msg00628.txt.bz2 >>>>> "Kyle" == Kyle Galloway writes: Kyle> The CHECK_INTERP_CLASS macro ensures that the class of the Kyle> method is interpreted. I think getLineTable should be updated to use the new macro. Kyle> + String *msg = reinterpret_cast (JvNewStringUTF (error)); I think you shouldn't need the cast here. Aside from these, this is ok. Thanks. Tom