From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26499 invoked by alias); 12 Aug 2010 16:22:13 -0000 Received: (qmail 26471 invoked by uid 22791); 12 Aug 2010 16:22:10 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Aug 2010 16:22:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7CGM53m032348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Aug 2010 12:22:06 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7CGM5J1016766; Thu, 12 Aug 2010 12:22:05 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7CGM42m011614; Thu, 12 Aug 2010 12:22:04 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1097A3781C7; Thu, 12 Aug 2010 10:22:04 -0600 (MDT) From: Tom Tromey To: Dmitrijs Ledkovs Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [java] [mingw] Fix (typos) compile errors. References: <877hjwelec.fsf@ubuntu.com> Date: Thu, 12 Aug 2010 16:22:00 -0000 In-Reply-To: <877hjwelec.fsf@ubuntu.com> (Dmitrijs Ledkovs's message of "Thu, 12 Aug 2010 03:15:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2010-q3/txt/msg00018.txt.bz2 >>>>> "Dmitrijs" == Dmitrijs Ledkovs writes: Dmitrijs> + { Dmitrijs> + jstring oserr = JvNewStringLatin1 (strerror (errno)); Dmitrijs> + throw new ::java::lang::UnsupportedOperationException Dmitrijs> + (JvNewStringLatin1 ("natGenerateSeed is not available for Win32 target.")->concat(oserr)); Dmitrijs> + } Andrew> OK. Actually, I don't think this is ok. Nothing sets errno here, so using it is incorrect. And, even if it were correct, the error message would be formatted strangely. Based on the error messages, I think all that is needed here is the addition of a "::" before "java". Dmitrijs, could you test the appended? Tom Index: natVMSecureRandomWin32.cc =================================================================== --- natVMSecureRandomWin32.cc (revision 162345) +++ natVMSecureRandomWin32.cc (working copy) @@ -1,6 +1,6 @@ // natVMSecureRandomWin32.cc - Native part of VMSecureRandom class for Win32. -/* Copyright (C) 2009 Free Software Foundation +/* Copyright (C) 2009, 2010 Free Software Foundation This file is part of libgcj. @@ -26,7 +26,7 @@ gnu::java::security::jce::prng::VMSecureRandom::natGenerateSeed(jbyteArray byte_array, jint offset, jint length) { if (length != 0) - throw new java::lang::UnsupportedOperationException ( + throw new ::java::lang::UnsupportedOperationException ( JvNewStringLatin1 ("natGenerateSeed is not available for Win32 target.")); return 0; }