From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25813 invoked by alias); 13 Mar 2007 18:53:06 -0000 Received: (qmail 25803 invoked by uid 22791); 13 Mar 2007 18:53:06 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Mar 2007 18:53:01 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l2DIqxAM023059 for ; Tue, 13 Mar 2007 14:52:59 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l2DIqwTJ019409; Tue, 13 Mar 2007 14:52:58 -0400 Received: from opsy.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l2DIqu7O030022; Tue, 13 Mar 2007 14:52:57 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A51058880D4; Tue, 13 Mar 2007 12:38:55 -0600 (MDT) To: Gary Benson Cc: java-patches@gcc.gnu.org Subject: Re: Patch: FYI: disable XML service files References: <20070312095509.GA4060@redhat.com> <20070313100134.GA4136@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Tue, 13 Mar 2007 18:53:00 -0000 In-Reply-To: <20070313100134.GA4136@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2007-q1/txt/msg00683.txt.bz2 >>>>> "Gary" == Gary Benson writes: >> I think removing the service files is the best thing to do anyway. >> Using the service files to mask some other bug is a bad approach IMO Gary> Having the service files is the right thing to do if you want JAXP Gary> parsers to be loaded only if they're endorsed. Having no service Gary> files is the right thing if you want them to be loaded regardless. It seems to me that if we want to ensure that this code in our XML implementation only loads things when they are endorsed, then it ought to be using the bootstrap class loader and not the system class loader, as it currently does. Using the service files to work around this seems hackish. I'm probably really confused though. I certainly feel confused. Tom