* Patch: FYI: -reverse argument for native2ascii
@ 2008-01-24 18:28 Tom Tromey
2008-01-24 18:40 ` [cp-patches] " Dalibor Topic
2008-01-27 23:21 ` Matthias Klose
0 siblings, 2 replies; 4+ messages in thread
From: Tom Tromey @ 2008-01-24 18:28 UTC (permalink / raw)
To: GNU Classpath Patches; +Cc: GCJ-patches
I'm checking this in to Classpath and libgcj.
Sun's native2ascii accepts -reverse, while we accept -reversed.
This changes Classpath to conform.
This bug came from the IcedTea build:
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=103
Tom
ChangeLog:
2008-01-24 Tom Tromey <tromey@redhat.com>
* resource/gnu/classpath/tools/native2ascii/messages.properties
(Native2ASCII.ReversedHelpCompat): New.
* tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
(createParser): Add -reverse. Update -reversed.
Index: resource/gnu/classpath/tools/native2ascii/messages.properties
===================================================================
RCS file: /cvsroot/classpath/classpath/resource/gnu/classpath/tools/native2ascii/messages.properties,v
retrieving revision 1.1
diff -u -r1.1 messages.properties
--- resource/gnu/classpath/tools/native2ascii/messages.properties 20 May 2006 22:10:31 -0000 1.1
+++ resource/gnu/classpath/tools/native2ascii/messages.properties 24 Jan 2008 14:27:37 -0000
@@ -1,5 +1,5 @@
# messages.properties -- English language messages
-# Copyright (C) 2006 Free Software Foundation, Inc.
+# Copyright (C) 2006, 2008 Free Software Foundation, Inc.
#
# This file is part of GNU Classpath.
#
@@ -41,3 +41,4 @@
Native2ASCII.EncodingArgName=NAME
Native2ASCII.EncodingSpecified=encoding already specified
Native2ASCII.ReversedHelp=convert from encoding to native
+Native2ASCII.ReversedHelpCompat=alias for -reverse (deprecated)
Index: tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
===================================================================
RCS file: /cvsroot/classpath/classpath/tools/gnu/classpath/tools/native2ascii/Native2ASCII.java,v
retrieving revision 1.5
diff -u -r1.5 Native2ASCII.java
--- tools/gnu/classpath/tools/native2ascii/Native2ASCII.java 8 Jan 2007 17:00:49 -0000 1.5
+++ tools/gnu/classpath/tools/native2ascii/Native2ASCII.java 24 Jan 2008 14:27:37 -0000
@@ -1,5 +1,5 @@
/* Native2ASCII.java - native2ascii program
- Copyright (C) 2003, 2007 Free Software Foundation, Inc.
+ Copyright (C) 2003, 2007, 2008 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -101,7 +101,17 @@
encoding = argument;
}
});
- result.add(new Option("reversed", Messages.getString("Native2ASCII.ReversedHelp")) //$NON-NLS-1$ //$NON-NLS-2$
+ result.add(new Option("reverse", Messages.getString("Native2ASCII.ReversedHelp")) //$NON-NLS-1$ //$NON-NLS-2$
+ {
+ public void parsed(String argument) throws OptionException
+ {
+ reversed = true;
+ }
+ });
+
+ // We mistakenly added the extra "d" in "reversed"; now we don't
+ // want to remove it, for backward compatibility.
+ result.add(new Option("reversed", Messages.getString("Native2ASCII.ReversedHelpCompat")) //$NON-NLS-1$ //$NON-NLS-2$
{
public void parsed(String argument) throws OptionException
{
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cp-patches] Patch: FYI: -reverse argument for native2ascii
2008-01-24 18:28 Patch: FYI: -reverse argument for native2ascii Tom Tromey
@ 2008-01-24 18:40 ` Dalibor Topic
2008-01-27 23:21 ` Matthias Klose
1 sibling, 0 replies; 4+ messages in thread
From: Dalibor Topic @ 2008-01-24 18:40 UTC (permalink / raw)
To: tromey; +Cc: GNU Classpath Patches, GCJ-patches
Tom Tromey wrote:
> I'm checking this in to Classpath and libgcj.
>
> Sun's native2ascii accepts -reverse, while we accept -reversed.
> This changes Classpath to conform.
>
> This bug came from the IcedTea build:
>
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=103
>
> Tom
>
> ChangeLog:
> 2008-01-24 Tom Tromey <tromey@redhat.com>
>
> * resource/gnu/classpath/tools/native2ascii/messages.properties
> (Native2ASCII.ReversedHelpCompat): New.
> * tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
> (createParser): Add -reverse. Update -reversed.
Please remove it instead, as no one is using it according to google or
Koders. 0 hits for gnative2ascii reversed on Google, and Ant does not
support reversion with the Kaffe/Classpath native2ascii.
cheers,
dalibor topic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch: FYI: -reverse argument for native2ascii
2008-01-24 18:28 Patch: FYI: -reverse argument for native2ascii Tom Tromey
2008-01-24 18:40 ` [cp-patches] " Dalibor Topic
@ 2008-01-27 23:21 ` Matthias Klose
2008-01-28 16:26 ` Tom Tromey
1 sibling, 1 reply; 4+ messages in thread
From: Matthias Klose @ 2008-01-27 23:21 UTC (permalink / raw)
To: tromey; +Cc: GCJ-patches
Tom Tromey schrieb:
> I'm checking this in to Classpath and libgcj.
>
> Sun's native2ascii accepts -reverse, while we accept -reversed.
> This changes Classpath to conform.
>
> This bug came from the IcedTea build:
>
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=103
>
> Tom
>
> ChangeLog:
> 2008-01-24 Tom Tromey <tromey@redhat.com>
>
> * resource/gnu/classpath/tools/native2ascii/messages.properties
> (Native2ASCII.ReversedHelpCompat): New.
> * tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
> (createParser): Add -reverse. Update -reversed.
?
libjava/classpath/tools/classes/gnu/classpath/tools/native2ascii/Native2ASCII$3.class
I see a new file generated after this patch, which is not checked in. Please
could you verify?
Thanks, Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Patch: FYI: -reverse argument for native2ascii
2008-01-27 23:21 ` Matthias Klose
@ 2008-01-28 16:26 ` Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2008-01-28 16:26 UTC (permalink / raw)
To: Matthias Klose; +Cc: GCJ-patches
>>>>> "Matthias" == Matthias Klose <doko@ubuntu.com> writes:
Matthias> I see a new file generated after this patch, which is not
Matthias> checked in. Please could you verify?
Oops, I don't know how I missed that. Thanks for pointing it out.
I've checked it in.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-28 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-24 18:28 Patch: FYI: -reverse argument for native2ascii Tom Tromey
2008-01-24 18:40 ` [cp-patches] " Dalibor Topic
2008-01-27 23:21 ` Matthias Klose
2008-01-28 16:26 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).