public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
Cc: roger@eyesopen.com (Roger Sayle),
	gcc-patches@gcc.gnu.org,         java-patches@gcc.gnu.org
Subject: Re: [Java PATCH] Fix libjava bootstrap issues on HP-UX 11.00
Date: Wed, 05 Jul 2006 17:46:00 -0000	[thread overview]
Message-ID: <m3zmfoc5jc.fsf@localhost.localdomain> (raw)
In-Reply-To: <200606290146.k5T1kmWk010640@hiauly1.hia.nrc.ca>

>>>>> "Dave" == John David Anglin <dave@hiauly1.hia.nrc.ca> writes:

>> 2006-06-28  Roger Sayle  <roger@eyesopen.com>
>> * include/posix.h: Ensure that _REENTRANT is defined on HP-UX.
>> * java/io/natFilePosix.cc: #include <platform.h>.

Dave> I'm not convinced this is the correct approach to fix the lack
Dave> of _REENTRANT being defined (see below).  This might also allow
Dave> building libjava on hpux 10.x.  There are some testsuite issues
Dave> which I haven't had a chance to look at in detail.

I never remember whether _REENTRANT is defined on all the
posix-threads-using platforms.  That's why I've been (half-heartedly)
pushing for a solution which is transparently HPUX-only... it is just
simpler to review :-)

If _REENTRANT is defined everywhere, then a patch like this one
is fine by me.  Otherwise I think it need to be handled some other
way, e.g., by changing the configure checks to realize that the
functions in question are not actually available.

Tom

  reply	other threads:[~2006-07-05 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-29  0:15 Roger Sayle
2006-06-29  1:30 ` Bryce McKinlay
2006-06-29  1:48   ` John David Anglin
2006-06-29  1:48 ` John David Anglin
2006-07-05 17:46   ` Tom Tromey [this message]
2006-07-05 21:49     ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zmfoc5jc.fsf@localhost.localdomain \
    --to=tromey@redhat.com \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=roger@eyesopen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).