From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10276 invoked by alias); 5 Jul 2006 17:46:09 -0000 Received: (qmail 10263 invoked by uid 22791); 5 Jul 2006 17:46:09 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Jul 2006 17:46:06 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k65Hjpgd024370; Wed, 5 Jul 2006 13:45:51 -0400 Received: from opsy.redhat.com (vpn50-206.rdu.redhat.com [172.16.50.206]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k65Hjoii026137; Wed, 5 Jul 2006 13:45:50 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id EC3EC69401F; Wed, 5 Jul 2006 11:42:15 -0600 (MDT) To: "John David Anglin" Cc: roger@eyesopen.com (Roger Sayle), gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [Java PATCH] Fix libjava bootstrap issues on HP-UX 11.00 References: <200606290146.k5T1kmWk010640@hiauly1.hia.nrc.ca> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Wed, 05 Jul 2006 17:46:00 -0000 In-Reply-To: <200606290146.k5T1kmWk010640@hiauly1.hia.nrc.ca> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q3/txt/msg00039.txt.bz2 >>>>> "Dave" == John David Anglin writes: >> 2006-06-28 Roger Sayle >> * include/posix.h: Ensure that _REENTRANT is defined on HP-UX. >> * java/io/natFilePosix.cc: #include . Dave> I'm not convinced this is the correct approach to fix the lack Dave> of _REENTRANT being defined (see below). This might also allow Dave> building libjava on hpux 10.x. There are some testsuite issues Dave> which I haven't had a chance to look at in detail. I never remember whether _REENTRANT is defined on all the posix-threads-using platforms. That's why I've been (half-heartedly) pushing for a solution which is transparently HPUX-only... it is just simpler to review :-) If _REENTRANT is defined everywhere, then a patch like this one is fine by me. Otherwise I think it need to be handled some other way, e.g., by changing the configure checks to realize that the functions in question are not actually available. Tom