From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16396 invoked by alias); 8 Mar 2011 15:28:58 -0000 Received: (qmail 16379 invoked by uid 22791); 8 Mar 2011 15:28:57 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 15:28:53 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p28FSoYY007902 for ; Tue, 8 Mar 2011 07:28:50 -0800 Received: from yxm8 (yxm8.prod.google.com [10.190.4.8]) by hpaq14.eem.corp.google.com with ESMTP id p28FSmWs031545 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 8 Mar 2011 07:28:49 -0800 Received: by yxm8 with SMTP id 8so2432034yxm.12 for ; Tue, 08 Mar 2011 07:28:47 -0800 (PST) Received: by 10.236.73.234 with SMTP id v70mr8317567yhd.12.1299598127782; Tue, 08 Mar 2011 07:28:47 -0800 (PST) Received: from coign.google.com ([67.218.107.6]) by mx.google.com with ESMTPS id z70sm559996yhc.34.2011.03.08.07.28.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2011 07:28:47 -0800 (PST) From: Ian Lance Taylor To: Rainer Orth Cc: Jim Meyering , "Joseph S. Myers" , gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [PATCH v2] Re: avoid useless if-before-free tests References: <87zkp9zmq0.fsf@rho.meyering.net> <877hc9r8w6.fsf_-_@rho.meyering.net> Date: Tue, 08 Mar 2011 15:28:00 -0000 In-Reply-To: (Rainer Orth's message of "Tue, 08 Mar 2011 15:30:40 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q1/txt/msg00053.txt.bz2 Rainer Orth writes: >> I found no ChangeLog for libgo and no other libgo-related entries. >> I suspect that means I should omit this change because it belongs upstream. > > Indeed, cf. libgo/README*. I've Cc'ed Ian who maintains this part of > GCC. Yes, libgo is upstream but in any case I'd prefer that you not make the change to libgo/runtime/go-select.c. I'm aware that free (NULL) is a no-op but I wrote the code that way because it is extremely unlikely that allocated_buffer != NULL. I am simply inlining the common case. Thanks. Ian