From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4123 invoked by alias); 20 Jun 2011 15:21:01 -0000 Received: (qmail 4088 invoked by uid 22791); 20 Jun 2011 15:21:00 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jun 2011 15:20:47 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 68702F37; Mon, 20 Jun 2011 17:20:45 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ybv39ErwBip9; Mon, 20 Jun 2011 17:20:43 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id B4484F36; Mon, 20 Jun 2011 17:20:42 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p5KFKeiT018669; Mon, 20 Jun 2011 17:20:40 +0200 (MEST) From: Rainer Orth To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini , Ralf Wildenhues , Ian Lance Taylor , Steve Ellcey , Richard Earnshaw , Ramana Radhakrishnan , Nick Clifton , Douglas Rupp , Tristan Gingold , Mike Stump , Kaz Kojima , David Edelsohn , Sterling Augustine , Arnaud Charlet , java-patches@gcc.gnu.org, Nicola Pero , libstdc++@gcc.gnu.org, Richard Sandiford Subject: Re: [build] Move unwinder to toplevel libgcc References: Date: Mon, 20 Jun 2011 15:21:00 -0000 In-Reply-To: (Joseph S. Myers's message of "Mon, 20 Jun 2011 15:11:00 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q2/txt/msg00081.txt.bz2 "Joseph S. Myers" writes: > On Mon, 20 Jun 2011, Rainer Orth wrote: > >> * Move all remaining unwinder-only macros to libgcc: UNW_IVMS_MODE, >> MD_UNW_COMPATIBLE_PERSONALITY_P, MD_FROB_UPDATE_CONTEXT. > > I don't see any sign of macros being poisoned in system.h. For macros > used in target-independent unwinder code - at least MD_FROB_UPDATE_CONTEXT > - that used to be defined in the host tm.h but now no longer should be, I > think poisoning in system.h is appropriate. Good point: I simply had forgotten about this. >> * The only unwinder-related macro I haven't moved is >> LIBGCC2_UNWIND_ATTRIBUTE. It is only defined gcc/config/mips/mips.h. >> I suppose we would need a libgcc equivalent of tm.h for that, >> something I didn't want to attack at this point. > > What about DWARF_ZERO_REG and PRE_GCC3_DWARF_FRAME_REGISTERS? > DWARF_REG_TO_UNWIND_COLUMN may be more complicated because it's used on > the host in rs6000.c (although not in target-independent host code) as > well as on the target - I suspect that will be a case where duplicating > the definition (with a comment in one place pointing to the other place as > needing to be kept consistent, and with the host-side copy renamed to > facilitate poisoning) may make sense. And all three are defined in > .h headers so your reason for moving them separately may apply. I guess. For the moment, I've concentrated on moving the sources themselves and the build logic since I've experienced the gcc side getting in the way of the libgcc side here. > (There are lots more macros used in the unwinder and on the host for which > macros predefined with -fbuilding-libgcc may be appropriate in a later > patch.) Certainly: your wiki entry gives a good overview. For the moment, I'll probably concentrate on the build side of things, though. I may attack gthr* stuff and fp-bit.[ch] next, both of which I can at least partially test on my targets. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University