From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7207 invoked by alias); 22 Oct 2014 15:05:28 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 7186 invoked by uid 89); 22 Oct 2014 15:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Oct 2014 15:05:27 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 00360200; Wed, 22 Oct 2014 17:05:23 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fdMhFchzMBz1; Wed, 22 Oct 2014 17:05:21 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 9A51F1FF; Wed, 22 Oct 2014 17:05:21 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.7+Sun/8.14.7/Submit) id s9MF5LkO002883; Wed, 22 Oct 2014 17:05:21 +0200 (CEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: java-patches@gcc.gnu.org Subject: [boehm-gc] Fix gnu11 fallout on SPARC Date: Wed, 22 Oct 2014 15:05:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SW-Source: 2014-q4/txt/msg00027.txt.bz2 --=-=-= Content-Type: text/plain Content-length: 1832 A couple of boehm-gc testcases are FAILing on Solaris/SPARC due to the recent gnu11 changes: FAIL: boehm-gc.c/gctest.c -O2 (test for excess errors) FAIL: boehm-gc.c/thread_leak_test.c -O2 (test for excess errors) FAIL: boehm-gc.lib/staticrootslib.c -O2 (test for excess errors) All of them are instances of same issue: /vol/gcc/src/hg/trunk/local/boehm-gc/testsuite/../include/gc.h:1020:31: warning: type defaults to 'int' in declaration of 'end' [-Wimplicit-int] # define GC_INIT() { extern end, etext; \ ^ GC_INIT(); ^ /vol/gcc/src/hg/trunk/local/boehm-gc/testsuite/../include/gc.h:1020:36: warning: type defaults to 'int' in declaration of 'etext' [-Wimplicit-int] # define GC_INIT() { extern end, etext; \ ^ GC_INIT(); ^ Given the comment in gc.h #if (defined(sparc) || defined(__sparc)) && defined(sun) /* * If you are planning on putting * the collector in a SunOS 5 dynamic library, you need to call GC_INIT() * from the statically loaded program section. * This circumvents a Solaris 2.X (X<=4) linker bug. */ # define GC_INIT() { extern end, etext; \ GC_noop(&end, &etext); } and the fact that mainline only supports Solaris 10 and up, I think the best course of action is to just remove the GC_INIT() expansion. This fixes the testsuite failures as tested with the appropriate runtest invocation on sparc-sun-solaris2.11. I intend to commit it to mainline once another bootstrap has finished successfully. Given that this code is no longer present in upstream boehm-gc, there's no point in reporting it there. Rainer 2014-10-22 Rainer Orth * include/gc.h [(sparc || __sparc) && sun] (GC_INIT): Remove comment and definition. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=sparc-boehm-gc-gnu11-fallout.patch Content-length: 775 # HG changeset patch # Parent 1f398ca16001e467a4d13fba76608e183ab2547b Fix gnu11 fallout on SPARC diff --git a/boehm-gc/include/gc.h b/boehm-gc/include/gc.h --- a/boehm-gc/include/gc.h +++ b/boehm-gc/include/gc.h @@ -1011,14 +1011,7 @@ GC_API void GC_register_has_static_roots * make that too hard. */ #if (defined(sparc) || defined(__sparc)) && defined(sun) - /* - * If you are planning on putting - * the collector in a SunOS 5 dynamic library, you need to call GC_INIT() - * from the statically loaded program section. - * This circumvents a Solaris 2.X (X<=4) linker bug. - */ -# define GC_INIT() { extern end, etext; \ - GC_noop(&end, &etext); } +# define GC_INIT() #else # if defined(__CYGWIN32__) || defined (_AIX) /* --=-=-= Content-Type: text/plain Content-length: 143 -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-=--