[libjava] XFAIL sourcelocation (PR libgcj/55637)

[libjava] XFAIL sourcelocation (PR libgcj/55637)

[Rainer Orth]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

The libjava sourcelocation output test has been FAILing on mainline for
more than a year, with no sign of anything happening to resolve that.
To reduce testsuite noise, I suggest to XFAIL the test.  In all mainline
test results from february, only a single set of testresults that
included libjava results (for ia64-suse-linux-gnu) didn't show those
failures.

Tested with the appropriate runtest invocations on i386-pc-solaris2.11
and x86_64-unknown-linux-gnu.

Ok for mainline?

	Rainer


2014-02-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR libgcj/55637
	* testsuite/libjava.lang/sourcelocation.xfail: New file.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libjava-testsuite-sourcelocation-xfail.patch --]
[-- Type: text/x-patch, Size: 353 bytes --]

# HG changeset patch
# Parent 6fd38b9012dee330d1343765cfe3cd0e06f33d33
XFAIL sourcelocation (PR libgcj/55637)

diff --git a/libjava/testsuite/libjava.lang/sourcelocation.xfail b/libjava/testsuite/libjava.lang/sourcelocation.xfail
new file mode 100644
--- /dev/null
+++ b/libjava/testsuite/libjava.lang/sourcelocation.xfail
@@ -0,0 +1,1 @@
+xfail-output

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]


-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: [libjava] XFAIL sourcelocation (PR libgcj/55637)

[Bryce McKinlay]

On Thu, Feb 20, 2014 at 12:05 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:

> The libjava sourcelocation output test has been FAILing on mainline for
> more than a year, with no sign of anything happening to resolve that.
> To reduce testsuite noise, I suggest to XFAIL the test.  In all mainline
> test results from february, only a single set of testresults that
> included libjava results (for ia64-suse-linux-gnu) didn't show those
> failures.
>
> Tested with the appropriate runtest invocations on i386-pc-solaris2.11
> and x86_64-unknown-linux-gnu.
>
> Ok for mainline?

OK.

The fix for this is to have libjava use libbackttrace to get source
line numbers, rather than rely on external addr2line.

Bryce

Re: [libjava] XFAIL sourcelocation (PR libgcj/55637)

[Rainer Orth]

Bryce McKinlay <bmckinlay@gmail.com> writes:

> The fix for this is to have libjava use libbackttrace to get source
> line numbers, rather than rely on external addr2line.

I see.  Doesn't sound exactly like 4.9 material, though.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: [libjava] XFAIL sourcelocation (PR libgcj/55637)

[Rainer Orth]

dominiq@lps.ens.fr (Dominique Dhumieres) writes:

>> The libjava sourcelocation output test has been FAILing on mainline for
>> more than a year, with no sign of anything happening to resolve that.
>> To reduce testsuite noise, I suggest to XFAIL the test.  ...
>
> Would it be possible to backport the fix to 4.8?

Sure, patch preapproved.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: [libjava] XFAIL sourcelocation (PR libgcj/55637)

[Dominique Dhumieres]

> The libjava sourcelocation output test has been FAILing on mainline for
> more than a year, with no sign of anything happening to resolve that.
> To reduce testsuite noise, I suggest to XFAIL the test.  ...

Would it be possible to backport the fix to 4.8?

TIA,

Dominique