From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30565 invoked by alias); 27 Feb 2006 12:30:39 -0000 Received: (qmail 30547 invoked by uid 22791); 27 Feb 2006 12:30:38 -0000 X-Spam-Check-By: sourceware.org Received: from mailout.TechFak.Uni-Bielefeld.DE (HELO mailout.TechFak.Uni-Bielefeld.DE) (129.70.136.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Feb 2006 12:30:36 +0000 Received: from manam.TechFak.Uni-Bielefeld.DE (manam.TechFak.Uni-Bielefeld.DE [129.70.137.47]) by momotombo.TechFak.Uni-Bielefeld.DE (8.12.11/8.12.11/TechFak/2005/05/30/sjaenick) with ESMTP id k1RCUVH7010139; Mon, 27 Feb 2006 13:30:32 +0100 (MET) Received: (from ro@localhost) by manam.TechFak.Uni-Bielefeld.DE (8.11.7p1+Sun/8.9.1) id k1RCUV302540; Mon, 27 Feb 2006 13:30:31 +0100 (MET) To: Andreas Tobler Cc: GCC Patches , Java Patches Subject: Re: [RFT] libffi testsuite cleanup warnings References: <4400D882.7040101@pop.agri.ch> Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII From: Rainer Orth Date: Mon, 27 Feb 2006 12:30:00 -0000 In-Reply-To: Andreas Tobler's message of "Sat, 25 Feb 2006 23:21:54 +0100" Message-ID: X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2006-q1/txt/msg00233.txt.bz2 Andreas Tobler writes: > 2006-02-25 Andreas Tobler > > * testsuite/libffi.call/closure_fn0.c: Clean up warnings discovered by > -W -Wall. I think it would be much more useful to describe the actual changes here instead of how you discovered that they are necessary/useful. > [2 ffi_test_warn2.diff ] > Index: testsuite/libffi.call/closure_fn0.c > =================================================================== > --- testsuite/libffi.call/closure_fn0.c (revision 111437) > +++ testsuite/libffi.call/closure_fn0.c (working copy) > @@ -10,7 +10,8 @@ > #include "ffitest.h" > > static void > -closure_test_fn0(ffi_cif* cif,void* resp,void** args, void* userdata) > +closure_test_fn0(ffi_cif* cif __attribute__ ((unused)), void* resp, void** args, > + void* userdata) > { > *(ffi_arg*)resp = > (int)*(unsigned long long *)args[0] + (int)(*(int *)args[1]) + It may be useful to use some macro that expands to __attribte__ ((unused)) when using GCC here instead of hardcoding it directly: libffi used to be usable with non-GCC compilers (I think there's a PR open to restore this ability in the GCC copy), and I'd appreciate if it remained that way (or at least doesn't become less so if it's avoidable). Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Faculty of Technology, Bielefeld University