From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15937 invoked by alias); 11 Apr 2012 15:57:33 -0000 Received: (qmail 15913 invoked by uid 22791); 11 Apr 2012 15:57:28 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_JC,T_RP_MATCHES_RCVD,T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 15:57:12 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 8165D7B6; Wed, 11 Apr 2012 17:57:11 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vjtlItoakWEm; Wed, 11 Apr 2012 17:57:08 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 44AF77B5; Wed, 11 Apr 2012 17:57:08 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q3BFv7mI009939; Wed, 11 Apr 2012 17:57:07 +0200 (MEST) From: Rainer Orth To: Andrew Haley Cc: Richard Guenther , GCC Patches , GCJ-patches Subject: Re: jcf-reader: support for JSR 292 classfile extensions References: <4F855B49.2070605@redhat.com> <4F858523.8000607@redhat.com> Date: Wed, 11 Apr 2012 15:57:00 -0000 In-Reply-To: <4F858523.8000607@redhat.com> (Andrew Haley's message of "Wed, 11 Apr 2012 14:20:35 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2012-q2/txt/msg00011.txt.bz2 --=-=-= Content-length: 2673 Andrew Haley writes: > On 04/11/2012 01:43 PM, Richard Guenther wrote: >> This breaks bootstrap for me: >> >> In file included from >> /space/rguenther/src/svn/trunk/gcc/java/jcf-parse.c:1009:0: >> /space/rguenther/src/svn/trunk/gcc/java/jcf-reader.c:550:1: error: >> 'int jcf_parse_bootstrap_methods(JCF*, int)' defined but not used >> [-Werror=unused-function] >> jcf_parse_bootstrap_methods (JCF* jcf, int attribute_length ATTRIBUTE_UNUSED) >> ^ >> cc1plus: all warnings being treated as errors >> make[3]: *** [java/jcf-parse.o] Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> > > Sorry. It also broke Java bootstrap on 32-bit targets: /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c: In function 'void print_constant(std::FILE*, JCF*, int, int)': /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c:929:64: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'uint32 {aka unsigned int}' [-Werror=format] fprintf (out, "Fieldref: %ld=", JPOOL_USHORT2 (jcf, index)); ^ /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c:936:65: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'uint32 {aka unsigned int}' [-Werror=format] fprintf (out, "Methodref: %ld=", JPOOL_USHORT2 (jcf, index)); ^ /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c:941:74: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'uint32 {aka unsigned int}' [-Werror=format] fprintf (out, "InterfaceMethodref: %ld=", JPOOL_USHORT2 (jcf, index)); ^ /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c:949:62: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'uint32 {aka unsigned int}' [-Werror=format] fprintf (out, "MethodType %ld: ", JPOOL_USHORT1 (jcf, index)); ^ /vol/gcc/src/hg/trunk/solaris/gcc/java/jcf-dump.c:957:68: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'uint32 {aka unsigned int}' [-Werror=format] fprintf (out, "bootstrap_method: %ld ", JPOOL_USHORT1 (jcf, index)); ^ The following patch got me into stage3 on i386-pc-solaris2.10 and amd64-pc-solaris2.10. Ok for mainline? Rainer 2012-04-11 Rainer Orth * jcf-dump.c (print_constant): Cast JPOOL_USHORT2, JPOOL_USHORT1 results to long to match formats. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=java-jcf-dump.patch Content-length: 1939 # HG changeset patch # Parent 94918a528698bab552dc2f8be5c1666444afca67 Fix java bootstrap on 32-bit targets diff --git a/gcc/java/jcf-dump.c b/gcc/java/jcf-dump.c --- a/gcc/java/jcf-dump.c +++ b/gcc/java/jcf-dump.c @@ -926,19 +926,20 @@ print_constant (FILE *out, JCF *jcf, int case 3: case 4: if (verbosity > 0) - fprintf (out, "Fieldref: %ld=", JPOOL_USHORT2 (jcf, index)); + fprintf (out, "Fieldref: %ld=", (long) JPOOL_USHORT2 (jcf, index)); print_constant (out, jcf, JPOOL_USHORT2 (jcf, index), 0); case 5: case 6: case 7: case 8: if (verbosity > 0) - fprintf (out, "Methodref: %ld=", JPOOL_USHORT2 (jcf, index)); + fprintf (out, "Methodref: %ld=", (long) JPOOL_USHORT2 (jcf, index)); print_constant (out, jcf, JPOOL_USHORT2 (jcf, index), 0); break; case 9: if (verbosity > 0) - fprintf (out, "InterfaceMethodref: %ld=", JPOOL_USHORT2 (jcf, index)); + fprintf (out, "InterfaceMethodref: %ld=", + (long) JPOOL_USHORT2 (jcf, index)); print_constant (out, jcf, JPOOL_USHORT2 (jcf, index), 0); break; } @@ -946,7 +947,7 @@ print_constant (FILE *out, JCF *jcf, int } case CONSTANT_MethodType: if (verbosity > 0) - fprintf (out, "MethodType %ld: ", JPOOL_USHORT1 (jcf, index)); + fprintf (out, "MethodType %ld: ", (long) JPOOL_USHORT1 (jcf, index)); print_signature (out, jcf, JPOOL_USHORT1 (jcf, index), 0); break; case CONSTANT_InvokeDynamic: @@ -954,7 +955,8 @@ print_constant (FILE *out, JCF *jcf, int uint16 name_and_type = JPOOL_USHORT2 (jcf, index); if (verbosity > 0) fprintf (out, "InvokeDynamic: "); - fprintf (out, "bootstrap_method: %ld ", JPOOL_USHORT1 (jcf, index)); + fprintf (out, "bootstrap_method: %ld ", + (long) JPOOL_USHORT1 (jcf, index)); if (verbosity == 2) fprintf (out, " name_and_type: %d=<", name_and_type); print_constant_terse (out, jcf, name_and_type, CONSTANT_NameAndType); --=-=-= Content-length: 144 -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-=--