public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
From: "andrew dot gray at anu dot edu dot au" <gcc-bugzilla@gcc.gnu.org> To: java-prs@gcc.gnu.org Subject: [Bug libgcj/14767] gcjlib under FreeBSD does not forward SIGSEGV to SA_SIGINFO handler Date: Thu, 08 Apr 2004 00:32:00 -0000 [thread overview] Message-ID: <20040408003221.17433.qmail@sources.redhat.com> (raw) In-Reply-To: <20040329041331.14767.andrew.gray@anu.edu.au> ------- Additional Comments From andrew dot gray at anu dot edu dot au 2004-04-08 00:31 ------- Hans, Thanks for your comments, in particular explaining under what circumstances GC_write_fault_hanlder would be forwarding SIGSEGV. Regarding your question about the patch: I have no reason to think FreeBSD needs to be excluded from the #if at line 124 of os_dep.c (which controls #defining setjmp to be sigsetjmp and #defining longjmp similarly). The reason I excluded it in the patch was to restrict the changes to the signal handling problem. The original code (from the gcc-3.4-20040310 snapshot, based on gc6.3alpha1) did not define SUNOS5SIGS for FreeBSD. So the original code did not include the #define for setjmp and longjmp under FreeBSD. My patch to gcconfig.h does define SUNOS5SIGS for FreeBSD version 4 or later. So to keep the behaviour of the original code my patch changes "defined (SUNOS5SIGS)" to "(defined SUNOS5SIGS) && !defined(FREEBSD)" at line 124. Sorry, I do not know if a plain setjmp can be used to jump out of a signal handler on FreeBSD. Also, I do not know if sigsetjmp is appreciably slower than plain setjmp. In quickly looking at the code, the most information about whether or not FreeBSD should use sigsetjmp that I found was your comment in the README.changes for gc6.3alpha4: - Made os_dep.c use sigsetjmp and SA_NODEFER for NetBSD. (Thanks to Christian Limpach.) (I generalized the patch to use sigsetjmp on all UNIX_LIKE platforms, admittedly a slightly risky move. But it may avoid similar problems on some other platforms. I also cleaned up the defn of UNIX_LIKE a bit. - Hans) Not knowing anything about how the GCC/GCJ people generally manage syncing the Boehm GC code in GCC with your upstream source, if my patch was going to be applied to GCC I would be inclined to leave it as is. That way the change to using sigsetjmp would occur when gc6.3alpha4 was imported into GCC. What do you think? Andrew -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14767
next prev parent reply other threads:[~2004-04-08 0:32 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-03-29 4:13 [Bug libgcj/14767] New: " andrew dot gray at anu dot edu dot au 2004-03-30 0:41 ` [Bug libgcj/14767] " andrew dot gray at anu dot edu dot au 2004-03-30 2:45 ` ljrittle at gcc dot gnu dot org 2004-03-30 7:40 ` andrew dot gray at anu dot edu dot au 2004-04-07 20:30 ` Hans dot Boehm at hp dot com 2004-04-08 0:32 ` andrew dot gray at anu dot edu dot au [this message] 2004-04-19 7:18 ` andrew dot gray at anu dot edu dot au
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20040408003221.17433.qmail@sources.redhat.com \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=java-prs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).