public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
From: "dannysmith at users dot sourceforge dot net" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug libgcj/16814] [win32] libgcj dpends on both winsock32dll and ws2_32.dll
Date: Sat, 31 Jul 2004 02:17:00 -0000	[thread overview]
Message-ID: <20040731021739.16869.qmail@sourceware.org> (raw)
In-Reply-To: <20040729014510.16814.dannysmith@users.sourceforge.net>


------- Additional Comments From dannysmith at users dot sourceforge dot net  2004-07-31 02:17 -------
Comment 6 appears to be directed to Ranjit, so I haven't done anything yet.

Here is the patch that I have tested on native mingw32 build

2004-07-31  Danny Smith  <dannysmith@users.sourceforge.net>

	PR gcj/16814
	* configure.in [host *mingw*] (SYSTEMSPEC): Remove -lwsock32.
	* configure. Regenerate.
	* include/win32.h: Explicitly include winsock2.h
	* win32.cc (_Jv_platform_initialize): Require version 2.2 of
	Winsock api.

Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/libjava/configure.in,v
retrieving revision 1.196
diff -c -3 -p -r1.196 configure.in
*** configure.in	23 Jul 2004 23:34:16 -0000	1.196
--- configure.in	31 Jul 2004 01:08:09 -0000
*************** AC_LINK_FILES(gnu/java/nio/channels/natF
*** 481,487 ****
  
  case "${host}" in
      *mingw*)
!       SYSTEMSPEC="-lgdi32 -lwsock32 -lws2_32"
        if test "${with_win32_nlsapi}" = "unicows"; then
          SYSTEMSPEC="-lunicows $SYSTEMSPEC"
        fi
--- 481,487 ----
  
  case "${host}" in
      *mingw*)
!       SYSTEMSPEC="-lgdi32 -lws2_32"
        if test "${with_win32_nlsapi}" = "unicows"; then
          SYSTEMSPEC="-lunicows $SYSTEMSPEC"
        fi
Index: win32.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/win32.cc,v
retrieving revision 1.21
diff -c -3 -p -r1.21 win32.cc
*** win32.cc	16 Dec 2003 22:54:21 -0000	1.21
--- win32.cc	31 Jul 2004 01:08:11 -0000
*************** _Jv_platform_initialize (void)
*** 256,262 ****
  {
    // Initialise winsock for networking
    WSADATA data;
!   if (WSAStartup (MAKEWORD (1, 1), &data))
      MessageBox (NULL, _T("Error initialising winsock library."), _T("Error"),
      MB_OK | MB_ICONEXCLAMATION);
  
--- 256,262 ----
  {
    // Initialise winsock for networking
    WSADATA data;
!   if (WSAStartup (MAKEWORD (2, 2), &data))
      MessageBox (NULL, _T("Error initialising winsock library."), _T("Error"),
      MB_OK | MB_ICONEXCLAMATION);
  
Index: include/win32.h
===================================================================
RCS file: /cvs/gcc/gcc/libjava/include/win32.h,v
retrieving revision 1.26
diff -c -3 -p -r1.26 win32.h
*** include/win32.h	16 Dec 2003 22:54:22 -0000	1.26
--- include/win32.h	31 Jul 2004 01:09:03 -0000
*************** details.  */
*** 22,27 ****
--- 22,29 ----
  
  // Includes
  #define WIN32_LEAN_AND_MEAN
+ // Force Winsock 2 interface.
+ #include <winsock2.h>
  #include <windows.h>
  #undef WIN32_LEAN_AND_MEAN
  #undef STRICT

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16814


  parent reply	other threads:[~2004-07-31  2:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-29  1:45 [Bug libgcj/16814] New: [mingw32] " dannysmith at users dot sourceforge dot net
2004-07-29  2:04 ` [Bug libgcj/16814] " mckinlay at redhat dot com
2004-07-29  2:19 ` dannysmith at users dot sourceforge dot net
2004-07-29  2:33 ` mckinlay at redhat dot com
2004-07-29  4:51 ` [Bug libgcj/16814] [win32] " pinskia at gcc dot gnu dot org
2004-07-29  6:53 ` rmathew at gcc dot gnu dot org
2004-07-29 14:46 ` mckinlay at redhat dot com
2004-07-31  2:17 ` dannysmith at users dot sourceforge dot net [this message]
2004-07-31 19:27 ` mckinlay at redhat dot com
2004-08-01  4:37 ` dannysmith at users dot sourceforge dot net
2004-08-01  8:43 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040731021739.16869.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=java-prs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).