public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/13720] gcc/libjava/java/lang/natSystem.cc: syntax error using "unsigned jint"
       [not found] <20040117152119.13720.roland.illig@gmx.de>
@ 2004-09-22 21:50 ` tromey at gcc dot gnu dot org
  0 siblings, 0 replies; only message in thread
From: tromey at gcc dot gnu dot org @ 2004-09-22 21:50 UTC (permalink / raw)
  To: java-prs


------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-22 21:50 -------
A couple notes on this patch.

First, we don't support compiling libgcj with a different
version of gcj other than the one it comes with.  The reason
for this is that gcj and libgcj are tightly coupled; for instance
gcj and libgcj both have information about the exact format of
java.lang.Class.

Second, I'm not sure this patch is correct.  E.g.,

+      || src_offset - (-count) >= 0 // check for possible integer overflow

Suppose src_offset==10 and count==3.
Then src_offset-(-count) == 7, which is >= 0,
but no integer overflow has occurred.
(This is a perfectly valid situation if the source
array's length is >= 13)

So, I'm closing this and not checking in the patch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13720


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-22 21:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20040117152119.13720.roland.illig@gmx.de>
2004-09-22 21:50 ` [Bug libgcj/13720] gcc/libjava/java/lang/natSystem.cc: syntax error using "unsigned jint" tromey at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).