public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
From: "bkorb at veritas dot com" <gcc-bugzilla@gcc.gnu.org> To: java-prs@gcc.gnu.org Subject: [Bug target/16300] Bug in vendor /usr/include/net/if.h needs fixincluding Date: Mon, 18 Oct 2004 05:06:00 -0000 [thread overview] Message-ID: <20041018050620.24978.qmail@sourceware.org> (raw) In-Reply-To: <20040630163127.16300.skunk@iskunk.org> ------- Additional Comments From bkorb at veritas dot com 2004-10-18 05:06 ------- Subject: Re: Bug in vendor /usr/include/net/if.h needs fixincluding giovannibajo at libero dot it wrote: > > ------- Additional Comments From giovannibajo at libero dot it 2004-10-16 03:30 ------- > CC'ing also Bruce because he's the fixincludes maintainer. Bruce, BTW, as a > developer which digs for the first time in fixincludes, let me say that > fixincludes/README is not very clear about how 'make check' is supposed to work. I can only fix things about which I get feedback so it incrementally gets better. I'm sorry you found it difficult. > Also, it does not explain if it is possible (and how) to use the test_text to > verify the correctness of the fix. When I run 'make check' I don't understand > if my new hack is being tested or not, and if it is correct or not. "test-text" should contain one or more examples of broken text that needs to be fixed. "make check" will spin a file with that text in it and run the "fixinc" program, then run a recursive "diff" between the patched files and a set of example files. Any differences are highlighted. So, when you make a fix, you should pretty well understand how the broken text ought to be transformed. In the "make check", you ought to see a diff that includes that new transform in the new output and not in the sample output. > 4. Rebuild the compiler and check the header causing the issue. > Make sure it is now properly handled. Add tests to the > "test_text" entry(ies) that validate your fix. This will > help ensure that future fixes won't negate your work. That means first, ensure the header you want fixed is fixed. Then, incorporate the brokenness in the "text-text" field. Then, ensure it is fixed in the sample output. Then, add the fixed result into the baseline sample files. Finally: > If you are having some problem with a system header that is either > broken by the manufacturer, or is broken by the fixinclude process, > then you will need to alter or add information to the include fix > definitions file, ``inclhack.def''. Please also send relevant > information to gcc-bugs@gcc.gnu.org, gcc-patches@gcc.gnu.org and, > please, to me: bkorb@gnu.org. That means send me email if you are still having problems. Regards, Bruce -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16300
next prev parent reply other threads:[~2004-10-18 5:06 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20040630163127.16300.skunk@iskunk.org> 2004-07-01 1:17 ` pinskia at gcc dot gnu dot org 2004-10-13 12:52 ` giovannibajo at libero dot it 2004-10-13 13:04 ` giovannibajo at libero dot it 2004-10-15 22:25 ` skunk at iskunk dot org 2004-10-15 23:43 ` giovannibajo at libero dot it 2004-10-15 23:44 ` giovannibajo at libero dot it 2004-10-16 3:30 ` giovannibajo at libero dot it 2004-10-18 5:06 ` bkorb at veritas dot com [this message] 2004-10-18 13:37 ` giovannibajo at libero dot it 2004-10-18 15:16 ` skunk at iskunk dot org 2004-10-18 16:06 ` bkorb at veritas dot com 2004-10-20 20:14 ` skunk at iskunk dot org 2004-10-20 20:22 ` bkorb at veritas dot com 2004-10-28 21:07 ` skunk at iskunk dot org 2004-10-29 1:31 ` giovannibajo at libero dot it [not found] <bug-16300-8784@http.gcc.gnu.org/bugzilla/> 2007-02-01 17:18 ` skunk at iskunk dot org 2009-02-28 0:41 ` skunk at iskunk dot org 2009-02-28 16:39 ` bkorb at gnu dot org 2009-08-07 21:13 ` skunk at iskunk dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20041018050620.24978.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=java-prs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).