public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug java/18091] Valgrind errors building libjava
Date: Mon, 03 Jan 2005 22:25:00 -0000 [thread overview]
Message-ID: <20050103222517.1502.qmail@sourceware.org> (raw)
In-Reply-To: <20041020200437.18091.drow@gcc.gnu.org>
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-01-03 22:25 -------
Not totally fixed.
The following is not fixed yet:
==21511== Source and destination overlap in memcpy(0x1BE08FEC, 0x1BE08FEC, 5)
==21511== at 0x1B904BCE: memcpy (mac_replace_strmem.c:113)
==21511== by 0x80D37F2: write_classfile (jcf-write.c:2800)
Yes this is harmless but we should not do memcpy at all.
The easy fix would be the following:
if (n > 0)
memcpy (new_ptr, old_ptr, n);
Changed to:
if (n > 0 && new_ptr != old_ptr)
memcpy (new_ptr, old_ptr, n);
The comment above explains how this can happen.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18091
next prev parent reply other threads:[~2005-01-03 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 20:04 [Bug java/18091] New: " drow at gcc dot gnu dot org
2004-10-20 20:24 ` [Bug java/18091] " pinskia at gcc dot gnu dot org
2004-10-20 20:27 ` pinskia at gcc dot gnu dot org
2004-10-20 20:49 ` mckinlay at redhat dot com
2004-10-20 21:04 ` pinskia at gcc dot gnu dot org
2004-10-21 14:38 ` cvs-commit at gcc dot gnu dot org
2004-12-16 14:29 ` aph at gcc dot gnu dot org
2005-01-03 22:25 ` pinskia at gcc dot gnu dot org [this message]
2005-01-21 2:38 ` cvs-commit at gcc dot gnu dot org
2005-01-21 2:39 ` tromey at gcc dot gnu dot org
2005-01-21 2:40 ` pinskia at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050103222517.1502.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=java-prs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).