[Bug java/18931] New: jar -> .so optimization problem

[Bug java/18931] New: jar -> .so optimization problem

[overholt at redhat dot com]

When natively compiling Eclipse jars with -O2, I get a compiler error:

$ gcj -fnew-verifier -fPIC -fjni -findirect-dispatch -shared -O2 -o
eclipse/startup.jar.so eclipse/startup.jar
org/eclipse/core/launcher/Main.java: In class 'org.eclipse.core.launcher.Main':
org/eclipse/core/launcher/Main.java: In method
'org.eclipse.core.launcher.Main.adjustTrailingSlash(java.net.URL,boolean)':
org/eclipse/core/launcher/Main.java:0: internal compiler error: in
copy_to_mode_reg, at explow.c:635

Compiling without -O2 (exact same other arguments) gives no errors.

startup.jar can be found here: 
http://dev.eclipse.org/viewcvs/index.cgi/~checkout~/org.eclipse.releng.basebuilder/

$ gcj --version
gcj (GCC) 4.0.0 20041130 (experimental)

-- 
           Summary: jar -> .so optimization problem
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: overholt at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug middle-end/18931] jar -> .so optimization problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-10 19:41 -------
What target is this on? i686-pc-linux?
I cannot reproduce this on 20041204 on powerpc-darwin.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|java                        |middle-end
           Keywords|                            |ice-on-valid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug middle-end/18931] jar -> .so optimization problem

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2004-12-10 19:43 -------
Yes, this is i686-linux.  I'll update to a more recent snapshot and see if I can
reproduce.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug middle-end/18931] jar -> .so optimization problem

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-12-14 20:16 -------
I got this to fail with yesterday's cvs head.
Removing the "-O2" is a workaround.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[aph at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aph at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
          Component|middle-end                  |java
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-12-16 14:59:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2004-12-16 15:00 -------
Bumping priority because this is possibly a front end bug that breaks many programs/

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
           Priority|P2                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-17 15:09 -------
Subject: Bug 18931

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aph@gcc.gnu.org	2004-12-17 15:09:12

Modified files:
	gcc/java       : ChangeLog convert.h expr.c typeck.c 

Log message:
	2004-12-17  Andrew Haley  <aph@redhat.com>
	
	PR java/18931
	* typeck.c (convert): Use a CONVERT_EXPR when converting to
	BOOLEAN_TYPE or CHAR_TYPE.
	(convert_to_boolean, convert_to_char) : Remove.
	* convert.h (convert_to_boolean, convert_to_char) : Remove.
	* expr.c (expand_load_internal): Do type conversion if type is not
	as required.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1522&r2=1.1523
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/convert.h.diff?cvsroot=gcc&r1=1.6&r2=1.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/expr.c.diff?cvsroot=gcc&r1=1.214&r2=1.215
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/typeck.c.diff?cvsroot=gcc&r1=1.73&r2=1.74



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-17 17:24 -------
Fixed on the mainline.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2005-01-05 21:49 -------
Using Jakub's gcc4 RPMs from Fedora rawhide (on Fedora Core 3), I'm getting:

gcj4 -O2 -fPIC -fjni -findirect-dispatch -shared -o jsch-0.1.17.so \
jsch-0.1.17.jar

com/jcraft/jsch/ChannelSftp.java: In method
'com.jcraft.jsch.ChannelSftp.ls(java.lang.String)':
com/jcraft/jsch/ChannelSftp.java:0: internal compiler error: in
remove_unreachable_regions, at except.c:694

This does not happen with no -O flag.

gcj4 --version:
gcj4 (GCC) 4.0.0 20041228 (Red Hat 4.0.0-0.17)
target:  i686-pc-linux

File:
http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.team.cvs.ssh2/jsch-0.1.17.jar

A similar error happens with jsch-0.1.16.jar.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |EH
   Target Milestone|4.0.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-01-05 23:53 -------
I narrowed this down to a small test case. The following code will cause the
crash when compiled to bytecode using Sun's javac 1.5.0 (but not when
byte-compiled with gcj or ecj).

public class PR18931 {

  public int getByte() 
  {
    return 1;
  }

  public void ls(String p) throws Exception{
    try{
      p.toString();

      int type=getByte();

      if(type!=100){
	throw new Exception("");
      }
      if(type==100) return;
      throw new Error();
    }
    catch(Exception e){
      throw new Exception("");
    }
  }
}

It occurs to me that we don't have any way to do regression tests for bytecode
compilation failures with bytecode produced by other compilers.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-01-05 23:57 -------
I suppose we could check in .class files.
That is mildly painful, if we ever want to change things.
I've occasionally wished we distributed our own jasmin-like
program for these situations.  This sort of thing would be
helpful for testing the verifier as well.

There is at least one test case that includes a binary blob
that it uses to make a new class on the fly.  That's probably
worse than committing a .class file though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] jar -> .so optimization problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-06 01:02 -------
Hmm, again this works for me on ppc-darwin, I don't know why.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] Java bytecode ICE in except.c remove_unreachable_regions

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2005-01-18 12:05 -------
It looks like my patch of 2004-12-17 fixes the original bug, but there is a
separate bug triggered by a different test case.  It shouldn't be attached to
this PR.

Please check that my patch really did fix the original bug and close this PR. 
Please open another PR against the new test case.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] Java bytecode ICE in except.c remove_unreachable_regions

[aph at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |SUSPENDED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] Java bytecode ICE in except.c remove_unreachable_regions

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2005-01-18 14:50 -------
Original bug verified fixed.  New PR filed as requested:  PR19505.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|SUSPENDED                   |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931

[Bug java/18931] Java bytecode ICE in except.c remove_unreachable_regions

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18931