[Bug java/19649] New: java.util.Date.getTimezoneOffset returns negated output

[Bug java/19649] New: java.util.Date.getTimezoneOffset returns negated output

[walters at redhat dot com]

Hi,

Here is a simple test:

public final class Test {
    public static void main(String[] args)  {
        System.out.println(new Date(5).getTimezoneOffset());
}
}

On gcj on my system, this returns -300.  On the JDK, it returns 300.  Attached
is a simple patch which shoudl correct the problem.

-- 
           Summary: java.util.Date.getTimezoneOffset returns negated output
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: walters at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug java/19649] java.util.Date.getTimezoneOffset returns negated output

[walters at redhat dot com]

------- Additional Comments From walters at redhat dot com  2005-01-27 00:39 -------
Created an attachment (id=8077)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8077&action=view)
correctly negate getTimezoneOffset


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|java                        |libgcj


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |16990
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[marco at gnome dot org]

------- Additional Comments From marco at gnome dot org  2005-01-28 17:35 -------
Colin, is this one the cause of the setTimeStamp/getTimeStamp mismatch with
postgre jdbc? I have a testcase for that one in case  it's of any use...

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[walters at redhat dot com]

------- Additional Comments From walters at redhat dot com  2005-01-28 20:16 -------
Yeah, I'm almost positive it's the cause.  At least I narrowed down this
behavior difference in JDK versus gcj, but it's possible there's another bug in
there.

Is the test suite patch for mauve?  I think they'd be interested in that.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[mckinlay at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-28 21:22:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-01-29 00:30 -------
I've put a test case for this in mauve:

gnu/testlet/java/util/Date/getTimezoneOffset.java

This test case also exposes some problems with libgcj's underlying TimeZone data. 

This patch looks correct, though. I'm going to check it in.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-01-29 00:37 -------
Turns out its already fixed in GNU Classpath. Re-syncing with their version.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-29 00:44 -------
Subject: Bug 19649

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bryce@gcc.gnu.org	2005-01-29 00:43:51

Modified files:
	libjava        : ChangeLog 
	libjava/java/util: Date.java 

Log message:
	2004-01-28  Jeroen Frijters  <jeroen@frijters.net>
	
	PR libgcj/19649
	* java/util/Date.java
	(Date(int,int,int), Date(int,int,int,int,int)): Delegate to other
	constructor.
	(Date(int,int,int,int,int,int)): Fixed to handle out-of-range
	arguments.
	(getTimezoneOffset): Inverted sign.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3296&r2=1.3297
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/util/Date.java.diff?cvsroot=gcc&r1=1.14&r2=1.15



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-01-29 00:45 -------
Fixed

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649

[Bug libgcj/19649] java.util.Date.getTimezoneOffset returns negated output

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19649