public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect
@ 2005-05-03 21:23 overholt at redhat dot com
2005-05-03 21:24 ` [Bug libgcj/21372] " overholt at redhat dot com
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: overholt at redhat dot com @ 2005-05-03 21:23 UTC (permalink / raw)
To: java-prs
According to the spec, FileChannel.tryLock() should return null in the event
that it cannot acquire a lock. libgcj's implementation does not currently do
this and returns a FileLock object even though the lock has not been acquired.
See attached test case.
--
Summary: FileChannel.tryLock() return value incorrect
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libgcj
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: overholt at redhat dot com
CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
@ 2005-05-03 21:24 ` overholt at redhat dot com
2005-05-03 21:28 ` overholt at redhat dot com
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: overholt at redhat dot com @ 2005-05-03 21:24 UTC (permalink / raw)
To: java-prs
------- Additional Comments From overholt at redhat dot com 2005-05-03 21:24 -------
Created an attachment (id=8810)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8810&action=view)
test case part 1
Run this part first.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
2005-05-03 21:24 ` [Bug libgcj/21372] " overholt at redhat dot com
@ 2005-05-03 21:28 ` overholt at redhat dot com
2005-05-03 21:29 ` overholt at redhat dot com
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: overholt at redhat dot com @ 2005-05-03 21:28 UTC (permalink / raw)
To: java-prs
------- Additional Comments From overholt at redhat dot com 2005-05-03 21:28 -------
Created an attachment (id=8811)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8811&action=view)
test case part 1
Run this file and leave it running while you try to run the second attachment
(forthcoming).
--
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8810 is|0 |1
obsolete| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
2005-05-03 21:24 ` [Bug libgcj/21372] " overholt at redhat dot com
2005-05-03 21:28 ` overholt at redhat dot com
@ 2005-05-03 21:29 ` overholt at redhat dot com
2005-05-03 21:44 ` overholt at redhat dot com
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: overholt at redhat dot com @ 2005-05-03 21:29 UTC (permalink / raw)
To: java-prs
------- Additional Comments From overholt at redhat dot com 2005-05-03 21:29 -------
Created an attachment (id=8812)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8812&action=view)
second part to the test case
Run this while TestLocking2 is running.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (2 preceding siblings ...)
2005-05-03 21:29 ` overholt at redhat dot com
@ 2005-05-03 21:44 ` overholt at redhat dot com
2005-05-03 21:54 ` tromey at gcc dot gnu dot org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: overholt at redhat dot com @ 2005-05-03 21:44 UTC (permalink / raw)
To: java-prs
------- Additional Comments From overholt at redhat dot com 2005-05-03 21:44 -------
Created an attachment (id=8813)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8813&action=view)
patch
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (3 preceding siblings ...)
2005-05-03 21:44 ` overholt at redhat dot com
@ 2005-05-03 21:54 ` tromey at gcc dot gnu dot org
2005-05-03 21:56 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-05-03 21:54 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-05-03 21:54 -------
This patch looks good to me.
Could you write a ChangeLog entry for it?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (4 preceding siblings ...)
2005-05-03 21:54 ` tromey at gcc dot gnu dot org
@ 2005-05-03 21:56 ` pinskia at gcc dot gnu dot org
2005-05-03 21:57 ` mckinlay at redhat dot com
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-05-03 21:56 UTC (permalink / raw)
To: java-prs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-05-03 21:56 -------
(In reply to comment #5)
> This patch looks good to me.
> Could you write a ChangeLog entry for it?
He did in <http://gcc.gnu.org/ml/java-patches/2005-q2/msg00371.html>
Confirmed,
--
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/java-
| |patches/2005-
| |q2/msg00371.html
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Keywords| |patch
Last reconfirmed|0000-00-00 00:00:00 |2005-05-03 21:56:01
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (5 preceding siblings ...)
2005-05-03 21:56 ` pinskia at gcc dot gnu dot org
@ 2005-05-03 21:57 ` mckinlay at redhat dot com
2005-05-03 22:39 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: mckinlay at redhat dot com @ 2005-05-03 21:57 UTC (permalink / raw)
To: java-prs
------- Additional Comments From mckinlay at redhat dot com 2005-05-03 21:57 -------
There is already a ChangeLog entry with the patch
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (6 preceding siblings ...)
2005-05-03 21:57 ` mckinlay at redhat dot com
@ 2005-05-03 22:39 ` cvs-commit at gcc dot gnu dot org
2005-05-03 22:47 ` cvs-commit at gcc dot gnu dot org
2005-05-03 22:48 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-03 22:39 UTC (permalink / raw)
To: java-prs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-03 22:38 -------
Subject: Bug 21372
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: tromey@gcc.gnu.org 2005-05-03 22:38:17
Modified files:
libjava : ChangeLog
libjava/java/nio/channels: FileLock.java
libjava/gnu/java/nio/channels: FileChannelImpl.java
Log message:
2005-05-03 Andrew Overholt <overholt@redhat.com>
PR libgcj/21372:
* gnu/java/nio/channels/FileChannelImpl.java: Return null if lock
could not be acquired.
* java/nio/channels/FileLock.java (toString): Re-implement to be
in line with other implementations.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3584&r2=1.3585
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/nio/channels/FileLock.java.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java.diff?cvsroot=gcc&r1=1.10&r2=1.11
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (7 preceding siblings ...)
2005-05-03 22:39 ` cvs-commit at gcc dot gnu dot org
@ 2005-05-03 22:47 ` cvs-commit at gcc dot gnu dot org
2005-05-03 22:48 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-03 22:47 UTC (permalink / raw)
To: java-prs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-03 22:47 -------
Subject: Bug 21372
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: tromey@gcc.gnu.org 2005-05-03 22:47:13
Modified files:
libjava : ChangeLog
libjava/java/nio/channels: FileLock.java
libjava/gnu/java/nio/channels: FileChannelImpl.java
Log message:
2005-05-03 Andrew Overholt <overholt@redhat.com>
PR libgcj/21372:
* gnu/java/nio/channels/FileChannelImpl.java: Return null if lock
could not be acquired.
* java/nio/channels/FileLock.java (toString): Re-implement to be
in line with other implementations.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.56&r2=1.3391.2.57
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/nio/channels/FileLock.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4&r2=1.4.40.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.7.4.2&r2=1.7.4.3
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libgcj/21372] FileChannel.tryLock() return value incorrect
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
` (8 preceding siblings ...)
2005-05-03 22:47 ` cvs-commit at gcc dot gnu dot org
@ 2005-05-03 22:48 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-05-03 22:48 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-05-03 22:48 -------
I checked in the fix to the trunk, the 4.0 branch, and Classpath.
Thanks for the clear test case and patch.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.0.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21372
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2005-05-03 22:48 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-03 21:23 [Bug libgcj/21372] New: FileChannel.tryLock() return value incorrect overholt at redhat dot com
2005-05-03 21:24 ` [Bug libgcj/21372] " overholt at redhat dot com
2005-05-03 21:28 ` overholt at redhat dot com
2005-05-03 21:29 ` overholt at redhat dot com
2005-05-03 21:44 ` overholt at redhat dot com
2005-05-03 21:54 ` tromey at gcc dot gnu dot org
2005-05-03 21:56 ` pinskia at gcc dot gnu dot org
2005-05-03 21:57 ` mckinlay at redhat dot com
2005-05-03 22:39 ` cvs-commit at gcc dot gnu dot org
2005-05-03 22:47 ` cvs-commit at gcc dot gnu dot org
2005-05-03 22:48 ` tromey at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).