[Bug libgcj/21285] New: gij fails to handle NullPointerException exception

[Bug libgcj/21285] New: gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

The following simple program prints "Aborted" on linux alpha if it is compiled
to byte code and later executed by "gij". The same program works correctly if
compiled to executable. (ant crashes with segmentation fault, but I could not
provide simple testcase :( ).

gij (GNU libgcj) version 4.0.0 20050423 (Red Hat 4.0.0-1)
glibc 2.3.4

--------------------------------
import java.util.*;

public class Test
{
   public static void main(String argv[])
     {
        Vector a = new Vector();
        Vector b = null;

        a.add("haha");
        b.add("haha");

        System.out.println("Test");
     }
}

Thank you.

-- 
           Summary: gij fails to handle NullPointerException exception
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tsv at solvo dot ru
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
 GCC build triplet: alpha-redhat-linux
  GCC host triplet: alpha-redhat-linux
GCC target triplet: alpha-redhat-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-05-03 18:23 -------
Could you run gij under gdb and attach a stack trace to this PR?
That might help.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-03 19:36 -------
Here it is. I tried to debug it, but it does a lot of things I have a little
knowlegde about.

(gdb) bt
#0  _Jv_Throw (value=0x20001b1b220) at ../../../libjava/exception.cc:113
#1  0x0000020000b6c7dc in _Jv_InterpMethod::run (this=0x20001c72be0,
    retp=0x11fc956a0, args=0x11fc955f0) at ../../../libjava/interpret.cc:3247
#2  0x0000020000b6ca88 in _Jv_InterpMethod::run_class (ret=0x11fc956a0,
    args=0x11fc955f0, __this=Variable "__this" is not available.
) at ../../../libjava/interpret.cc:302
#3  0x00000200010edad0 in ffi_java_translate_args (cif=0x20001c61358,
    rvalue=0x11fc956a0, avalue=0x11fc95650, user_data=0x20001c61318)
    at ../../../libffi/src/java_raw_api.c:309
#4  0x00000200010ee044 in ffi_closure_osf_inner (closure=Variable "closure" is
not available.
)
    at ../../../libffi/src/alpha/ffi.c:248
#5  0x00000200010ee1d4 in ffi_closure_osf ()
    at ../../../libffi/src/alpha/osf.S:158
#6  0x0000020000b841c8 in gnu::java::lang::MainThread::call_main (
    this=0x20001b7fe30) at ../../../libjava/gnu/java/lang/natMainThread.cc:47
#7  0x0000020001bed400 in ?? ()
warning: Hit heuristic-fence-post without finding
warning: enclosing function for address 0x20001bed400
#8  0x0000020000b841c8 in gnu::java::lang::MainThread::call_main (
    this=0x20001b7fe30) at ../../../libjava/gnu/java/lang/natMainThread.cc:47
#9  0x0000020001bed400 in ?? ()
warning: Hit heuristic-fence-post without finding
warning: enclosing function for address 0x20001bed400
#10 0x0000020000b841c8 in gnu::java::lang::MainThread::call_main (
    this=0x20001b7fe30) at ../../../libjava/gnu/java/lang/natMainThread.cc:47
#11 0x000002000003108c in main () from /usr/lib/libgij.so.6
#12 0x0000000000000002 in ?? ()
Cannot access memory at address 0xfffffffffffffffe
(gdb)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-03 19:46 -------
Here is another stack dump from attempt of running the "ant":
exec "/usr/lib/jvm/java/bin/java" -classpath
"/usr/share/java/ant.jar:/usr/share/java/ant-launcher.jar:/usr/share/java/jaxp_parser_impl.jar:/usr/share/java/xml-commons-apis.jar:/usr/share/java/jakarta-commons-logging.jar:/usr/share/java/ant/ant-commons-logging.jar:/usr/lib/jvm/java/lib/tools.jar:/usr/share/java/jdtcore.jar"
-Dant.home="/usr/share/ant" -Dant.library.dir="/usr/share/ant/lib"
org.apache.tools.ant.launch.Launcher -lib ""

The "ra" member of context parameter has bad value, but how it got it ... I
could not trace.

This issue might not be related to original one, but it fails in unwind logic
too (so it could give more info).

My test case (and "ant") worked on gcc 3.4.3 version built on the environment.

If you need more info about my environment I would glad to tell.

Thank you.

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 2199023384624 (LWP 32406)]
0x0000020001886254 in alpha_fallback_frame_state (context=0x11f831c28,
    fs=0x11f831e68) at ../../gcc/config/alpha/linux-unwind.h:45
45        if (pc[0] != 0x47fe0410               /* mov $30,$16 */
(gdb) bt
#0  0x0000020001886254 in alpha_fallback_frame_state (context=0x11f831c28,
    fs=0x11f831e68) at ../../gcc/config/alpha/linux-unwind.h:45
#1  0x0000020001887eac in uw_frame_state_for (context=0x11f831c28,
    fs=0x11f831e68) at ../../gcc/unwind-dw2.c:978
#2  0x000002000188a0bc in _Unwind_Backtrace (
    trace=0x20001981700 <backtrace_helper>, trace_argument=0x11f832320)
    at ../../gcc/unwind.inc:296
#3  0x0000020001981804 in backtrace () from /lib/tls/libc.so.6.1
#4  0x0000020000b833ec in gnu::gcj::runtime::StackTrace::fillInStackTrace (
    this=0x20002839188, maxlen=Variable "maxlen" is not available.
)
    at ../../../libjava/gnu/gcj/runtime/natStackTrace.cc:60
#5  0x0000020000c5eaf4 in gnu.gcj.runtime.StackTrace.StackTrace(int) (
    this=0x20002839188, n=128)
    at ../../../libjava/gnu/gcj/runtime/StackTrace.java:67
#6  0x0000020000bce9c4 in
java.lang.VMThrowable.fillInStackTrace(java.lang.Throwable) (t=Variable "t" is
not available.
) at ../../../libjava/java/lang/VMThrowable.java:80
#7  0x0000020000bcbd20 in java.lang.Throwable.fillInStackTrace() (
    this=0x200027f99a0) at ../../../libjava/java/lang/Throwable.java:502
#8  0x0000020000bcb2d4 in java.lang.Throwable.Throwable(java.lang.String) (
    this=0x200027f99a0, message=0x2000284d540)
    at ../../../libjava/java/lang/Throwable.java:157
#9  0x0000020000bb4de8 in java.lang.Exception.Exception(java.lang.String) (
    this=Variable "this" is not available.
) at ../../../libjava/java/lang/Exception.java:77
#10 0x0000020000bdb818 in java.io.IOException.IOException(java.lang.String) (
    this=Variable "this" is not available.
) at ../../../libjava/java/io/IOException.java:71
#11 0x0000020000b7e294 in gnu::gcj::Core::create (name=Variable "name" is not
available.
)
    at ../../../libjava/gnu/gcj/natCore.cc:111
#12 0x0000020000c9d0a8 in gnu.java.net.protocol.core.Connection.connect() (
    this=Variable "this" is not available.
) at ../../../libjava/gnu/java/net/protocol/core/Connection.java:50
#13 0x0000020000c9d348 in gnu.java.net.protocol.core.Connection.getHeaders() (
    this=0x20002842f78)
    at ../../../libjava/gnu/java/net/protocol/core/Connection.java:154
#14 0x0000020000c9d6d8 in
gnu.java.net.protocol.core.Connection.getHeaderField(java.lang.String)
(this=0x20002842f78, name=0x20001ac9200)
    at ../../../libjava/gnu/java/net/protocol/core/Connection.java:69
#15 0x0000020000d35174 in
java.net.URLConnection.getHeaderFieldInt(java.lang.String, int) (this=Variable
"this" is not available.
) at ../../../libjava/java/net/URLConnection.java:343
#16 0x0000020000d34f98 in java.net.URLConnection.getContentLength()
(this=Variable "this" is not available.
)
    at ../../../libjava/java/net/URLConnection.java:220
#17 0x0000020000d320a4 in
java.net.URLClassLoader$RemoteURLLoader.getResource(java.lang.String)
(this=0x20001b1d428, name=0x200028480c0)
    at ../../../libjava/java/net/URLClassLoader.java:475
#18 0x0000020000d33b74 in java.net.URLClassLoader.findClass(java.lang.String) (
    this=0x20001b7fea0, className=0x2000284d5c0)
    at ../../../libjava/java/net/URLClassLoader.java:921
#19 0x0000020000c58d84 in
gnu.gcj.runtime.BootClassLoader.bootLoadClass(java.lang.String)
(this=0x20001b7fea0, name=0x2000284d5c0)
---Type <return> to continue, or q <return> to quit---
    at ../../../libjava/gnu/gcj/runtime/BootClassLoader.java:52
#20 0x0000020000b9bf44 in java::lang::VMClassLoader::loadClass (
    name=0x2000284d5c0, resolve=0 '\0')
    at ../../../libjava/java/lang/natVMClassLoader.cc:205
#21 0x0000020000bb2e7c in java.lang.ClassLoader.loadClass(java.lang.String,
boolean) (this=0x20001b7ff80, name=0x2000284d5c0, resolve=false)
    at ../../../libjava/java/lang/ClassLoader.java:304
#22 0x0000020000bb2e5c in java.lang.ClassLoader.loadClass(java.lang.String,
boolean) (this=0x20001b7ff10, name=0x2000284d5c0, resolve=false)
    at ../../../libjava/java/lang/ClassLoader.java:310
#23 0x0000020000bb2990 in java.lang.ClassLoader.loadClass(java.lang.String) (
    this=Variable "this" is not available.
) at ../../../libjava/java/lang/ClassLoader.java:260
#24 0x0000020000b90ff8 in _Jv_FindClass (name=0x20002614dc8,
    loader=0x20001b7ff10) at ../../../libjava/java/lang/natClassLoader.cc:242
#25 0x0000020000b61a30 in _Jv_Linker::resolve_pool_entry (klass=0x2000261fcb0,
    index=173) at ../../../libjava/link.cc:240
#26 0x0000020000b69df8 in _Jv_InterpMethod::run (this=0x20001ce2bb0,
    retp=0x11f832d20, args=0x11f832c70) at ../../../libjava/interpret.cc:2956
#27 0x0000020000b6cb9c in _Jv_InterpMethod::run_normal (ret=Variable "ret" is
not available.
)
    at ../../../libjava/interpret.cc:277
#28 0x00000200010edad0 in ffi_java_translate_args (cif=0x20001d4fd80,
    rvalue=0x11f832d20, avalue=0x11f832cd0, user_data=0x20001d4fd40)
    at ../../../libffi/src/java_raw_api.c:309
#29 0x00000200010ee044 in ffi_closure_osf_inner (closure=Variable "closure" is
not available.
)
    at ../../../libffi/src/alpha/ffi.c:248
#30 0x00000200010ee1d4 in ffi_closure_osf ()
    at ../../../libffi/src/alpha/osf.S:158
#31 0x0000020000b8fe38 in java::lang::Class::newInstance (this=Variable "this"
is not available.
)
    at ../../../libjava/java/lang/natClass.cc:703
#32 0x0000000000000001 in ?? ()
Cannot access memory at address 0xfffffffffffffffd
(gdb) p context
$1 = (struct _Unwind_Context *) 0x11f831c28
(gdb) p *context
$2 = {reg = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x11f832cf8,
    0x11f832da8, 0x11f832ca8, 0x11f832db0, 0x11f832cb8, 0x11f832b70,
    0x11f832d00, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
    0x11f832da0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x11f831be0, 0x11f831be8,
    0x11f831bf0, 0x11f831bf8, 0x11f831c00, 0x11f831c08, 0x11f831c10,
    0x11f831c18, 0x0 <repeats 23 times>}, cfa = 0x11f832dc0, ra = 0x1,
  lsda = 0x0, bases = {tbase = 0x0, dbase = 0x0, func = 0x20000b8fcf0},
  args_size = 0}
(gdb)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-03 19:52 -------
Hmm, could it be that the libffi does not handle exceptions.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-03 20:54 -------
How could I check that?
I ran "make check" in libffi library and it has not produced any errors.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-03 21:49 -------
So far I was able to debug to interpret.cc:3211.
It seems that unwind logic worked correctly (as far as I could understand) and
catch handler was called. The logic here didn't find exception handler and
"thrown" exception again that lead to "abort" (since no more handlers were found).

I am going to recompile interpret.cc without optimization and check again if my
assumptions are true. Could DIRECT_THREADED define doesn't work on alpha linux?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug middle-end/21285] gij fails to handle NullPointerException exception

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-03 21:51 -------
Hmm, maybe this is not a bug in libgcj and in the middle-end related to EH.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libgcj                      |middle-end
           Keywords|                            |EH, wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug middle-end/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-03 23:03 -------
Ok, somehow generic exception handler is missed on linux alpha. At this point I
don't undestand how and leave it for professionals.

Just check the same test on:
gij (GNU libgcj) version 3.4.3 20050227 (Red Hat 3.4.3-22.fc3)

The output is:
gij Test
Exception in thread "main" java.lang.NullPointerException
   at Test.main(java.lang.String[]) (Unknown Source)

Thank you.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug middle-end/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-05 13:13 -------
I put my code into try/catch block and the exception was successfully caught.
How general EH is supposed to be called? Could it be arch specific?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug middle-end/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-06 22:36 -------
Ok, I think I did find the problem. The unwind logic could not unwind deeper
than "ffi_closure_osf" function defined in libffi/src/alpha/osf.S (gdb showed
call stack like corrupted).
I checked number of bytes reserved from stack in ".frame" directive for the
functions and number of bytes for call stack described in FDEs in ".eh_frame"
section. They are different by 16 bytes for each function. I modified ".frame"
directive to reserve number of bytes as defined by FDEs (although changing of
FDEs would be easier) and my test cases started to work (even "ant" stopped
crashing).

Please, review the attached patch to libffi/src/alpha/osf.S file.

Thank you.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug middle-end/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-06 22:39 -------
Created an attachment (id=8832)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8832&action=view)
Fixes call frame size mismatch in ".frame" and ".eh_frame"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-06 22:47 -------
CCing RTH since he is the alpha maintainer.


Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
          Component|middle-end                  |libffi
     Ever Confirmed|                            |1
           Keywords|EH, wrong-code              |
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-06 22:47:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2005-05-08 18:26 -------
It's the unwind info that should be changed, not the code.
I'll do it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rth at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-05-06 22:47:26         |2005-05-08 18:26:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-08 18:30 -------
(In reply to comment #13)
> It's the unwind info that should be changed, not the code.
> I'll do it.
Thank you very much. I just understand the code better than DWARF stuff. :)



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-08 23:24 -------
Subject: Bug 21285

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rth@gcc.gnu.org	2005-05-08 23:23:51

Modified files:
	libffi         : ChangeLog 
	libffi/src/alpha: osf.S 

Log message:
	PR libffi/21285
	* src/alpha/osf.S: Update unwind into to match code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/ChangeLog.diff?cvsroot=gcc&r1=1.233&r2=1.234
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/src/alpha/osf.S.diff?cvsroot=gcc&r1=1.9&r2=1.10



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2005-05-09 13:44 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-09 13:54 -------
Subject: Bug 21285

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	rth@gcc.gnu.org	2005-05-09 13:39:35

Modified files:
	libffi         : ChangeLog 
	libffi/src/alpha: osf.S 

Log message:
	PR libffi/21285
	* src/alpha/osf.S: Update unwind into to match code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.222.2.1&r2=1.222.2.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/src/alpha/osf.S.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.72.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-09 13:55 -------
Subject: Bug 21285

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	rth@gcc.gnu.org	2005-05-09 13:40:16

Modified files:
	libffi         : ChangeLog 
	libffi/src/alpha: osf.S 

Log message:
	PR libffi/21285
	* src/alpha/osf.S: Update unwind into to match code.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.153.4.12&r2=1.153.4.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libffi/src/alpha/osf.S.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.9&r2=1.9.10.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libgcj/21285] gij fails to handle NullPointerException exception

[tsv at solvo dot ru]

------- Additional Comments From tsv at solvo dot ru  2005-05-12 08:25 -------
Your patch works a lot better than mine. Just tested and ant started to work.
Thank you very much.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
          Component|libffi                      |libgcj


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285

[Bug libffi/21285] gij fails to handle NullPointerException exception

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
          Component|libgcj                      |libffi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21285