public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
* [Bug libgcj/21753] New: String.substring sharing heuristic should be improved
@ 2005-05-25 15:03 mckinlay at redhat dot com
2005-05-25 15:36 ` [Bug libgcj/21753] " pinskia at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: mckinlay at redhat dot com @ 2005-05-25 15:03 UTC (permalink / raw)
To: java-prs
The heuristic for sharing String data in String.substring() can result in
significant memory bloat in certain cases.
Currently, it will always share String data unless the resulting substring is <=
8 characters in size. In many applications, it seems common for the initial
string to be discarded once a substring has been taken - thus it probably makes
sense to share only when the substring represents a significant proportion of
the original string's size.
See this thread for more information:
http://gcc.gnu.org/ml/java-patches/2005-q2/msg00449.html
--
Summary: String.substring sharing heuristic should be improved
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libgcj
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: mckinlay at redhat dot com
CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libgcj/21753] String.substring sharing heuristic should be improved 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com @ 2005-05-25 15:36 ` pinskia at gcc dot gnu dot org 2005-06-01 3:17 ` tromey at gcc dot gnu dot org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu dot org @ 2005-05-25 15:36 UTC (permalink / raw) To: java-prs ------- Additional Comments From pinskia at gcc dot gnu dot org 2005-05-25 15:36 ------- Confirmed -- What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed| |1 Last reconfirmed|0000-00-00 00:00:00 |2005-05-25 15:36:21 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libgcj/21753] String.substring sharing heuristic should be improved 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com 2005-05-25 15:36 ` [Bug libgcj/21753] " pinskia at gcc dot gnu dot org @ 2005-06-01 3:17 ` tromey at gcc dot gnu dot org 2005-06-01 15:52 ` cvs-commit at gcc dot gnu dot org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: tromey at gcc dot gnu dot org @ 2005-06-01 3:17 UTC (permalink / raw) To: java-prs ------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-01 03:17 ------- I'm handling this -- What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at gcc dot gnu |tromey at gcc dot gnu dot |dot org |org Status|NEW |ASSIGNED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libgcj/21753] String.substring sharing heuristic should be improved 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com 2005-05-25 15:36 ` [Bug libgcj/21753] " pinskia at gcc dot gnu dot org 2005-06-01 3:17 ` tromey at gcc dot gnu dot org @ 2005-06-01 15:52 ` cvs-commit at gcc dot gnu dot org 2005-06-01 15:53 ` cvs-commit at gcc dot gnu dot org 2005-06-01 15:54 ` tromey at gcc dot gnu dot org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu dot org @ 2005-06-01 15:52 UTC (permalink / raw) To: java-prs ------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-01 15:52 ------- Subject: Bug 21753 CVSROOT: /cvs/gcc Module name: gcc Branch: gcc-4_0-branch Changes by: tromey@gcc.gnu.org 2005-06-01 15:51:58 Modified files: libjava : ChangeLog libjava/java/lang: natString.cc Log message: PR libgcj/21753: * java/lang/natString.cc (substring): Changed sharing heuristic. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.80&r2=1.3391.2.81 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/lang/natString.cc.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.36.12.1&r2=1.36.12.2 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libgcj/21753] String.substring sharing heuristic should be improved 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com ` (2 preceding siblings ...) 2005-06-01 15:52 ` cvs-commit at gcc dot gnu dot org @ 2005-06-01 15:53 ` cvs-commit at gcc dot gnu dot org 2005-06-01 15:54 ` tromey at gcc dot gnu dot org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu dot org @ 2005-06-01 15:53 UTC (permalink / raw) To: java-prs ------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-01 15:53 ------- Subject: Bug 21753 CVSROOT: /cvs/gcc Module name: gcc Changes by: tromey@gcc.gnu.org 2005-06-01 15:52:45 Modified files: libjava : ChangeLog libjava/java/lang: natString.cc Log message: PR libgcj/21753: * java/lang/natString.cc (substring): Changed sharing heuristic. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3640&r2=1.3641 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/lang/natString.cc.diff?cvsroot=gcc&r1=1.38&r2=1.39 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libgcj/21753] String.substring sharing heuristic should be improved 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com ` (3 preceding siblings ...) 2005-06-01 15:53 ` cvs-commit at gcc dot gnu dot org @ 2005-06-01 15:54 ` tromey at gcc dot gnu dot org 4 siblings, 0 replies; 6+ messages in thread From: tromey at gcc dot gnu dot org @ 2005-06-01 15:54 UTC (permalink / raw) To: java-prs ------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-01 15:54 ------- I've checked in a fix. -- What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |4.0.1 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21753 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-06-01 15:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2005-05-25 15:03 [Bug libgcj/21753] New: String.substring sharing heuristic should be improved mckinlay at redhat dot com 2005-05-25 15:36 ` [Bug libgcj/21753] " pinskia at gcc dot gnu dot org 2005-06-01 3:17 ` tromey at gcc dot gnu dot org 2005-06-01 15:52 ` cvs-commit at gcc dot gnu dot org 2005-06-01 15:53 ` cvs-commit at gcc dot gnu dot org 2005-06-01 15:54 ` tromey at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).