public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug java/21844] New: miscompilation of LinkedHashMap
@ 2005-05-31 18:07 tromey at gcc dot gnu dot org
2005-06-03 20:02 ` [Bug java/21844] " tromey at gcc dot gnu dot org
` (9 more replies)
0 siblings, 10 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-05-31 18:07 UTC (permalink / raw)
To: java-prs
This happens with 4.1 but not with 4.0.x.
It occurs even without -O.
I believe java.util.LinkedHashMap is being miscompiled.
You can see this by trying the test case in PR 20273.
For me, it crashes.
In the debugger I observed that this line from
LinkedHashMap$LinkedHashEntry.access() is incrementing
the 'succ' field and not the modCount field:
modCount++;
--
Summary: miscompilation of LinkedHashMap
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: java
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tromey at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
dot org
GCC build triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
@ 2005-06-03 20:02 ` tromey at gcc dot gnu dot org
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-03 20:02 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-03 20:02 -------
I have a reduced test case, consisting of 2 files.
Compile like so:
gcj --main=t -o T base.java t.java
I get:
opsy. ./T
306833
The result should be '8'.
At the moment I suspect the recent accessor patch.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
2005-06-03 20:02 ` [Bug java/21844] " tromey at gcc dot gnu dot org
@ 2005-06-03 20:03 ` tromey at gcc dot gnu dot org
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
` (7 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-03 20:03 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-03 20:03 -------
Created an attachment (id=9023)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9023&action=view)
base class
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
2005-06-03 20:02 ` [Bug java/21844] " tromey at gcc dot gnu dot org
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
@ 2005-06-03 20:03 ` tromey at gcc dot gnu dot org
2005-06-03 20:11 ` pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-03 20:03 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-03 20:03 -------
Created an attachment (id=9024)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=9024&action=view)
main class
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (2 preceding siblings ...)
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
@ 2005-06-03 20:11 ` pinskia at gcc dot gnu dot org
2005-06-03 20:14 ` [Bug java/21844] [4.1 Regression] " pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-03 20:11 UTC (permalink / raw)
To: java-prs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-06-03 20:11 -------
Hmm, inner functions going back again :(.
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |18131
nThis| |
Keywords| |wrong-code
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (3 preceding siblings ...)
2005-06-03 20:11 ` pinskia at gcc dot gnu dot org
@ 2005-06-03 20:14 ` pinskia at gcc dot gnu dot org
2005-06-03 21:18 ` tromey at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-03 20:14 UTC (permalink / raw)
To: java-prs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-06-03 20:14 -------
Confirmed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Known to fail| |4.1.0
Known to work| |4.0.0
Last reconfirmed|0000-00-00 00:00:00 |2005-06-03 20:14:34
date| |
Summary|miscompilation of |[4.1 Regression]
|LinkedHashMap |miscompilation of
| |LinkedHashMap
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (4 preceding siblings ...)
2005-06-03 20:14 ` [Bug java/21844] [4.1 Regression] " pinskia at gcc dot gnu dot org
@ 2005-06-03 21:18 ` tromey at gcc dot gnu dot org
2005-06-03 22:03 ` tromey at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-03 21:18 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-03 21:17 -------
The problem is that nested_field_access_p() returns 0 for the
reference to modCount. It should return 1 as this is a nested
access.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (5 preceding siblings ...)
2005-06-03 21:18 ` tromey at gcc dot gnu dot org
@ 2005-06-03 22:03 ` tromey at gcc dot gnu dot org
2005-06-13 19:20 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-03 22:03 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-03 22:03 -------
I'm testing a patch.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tromey at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2005-06-03 20:14:34 |2005-06-03 22:03:22
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (6 preceding siblings ...)
2005-06-03 22:03 ` tromey at gcc dot gnu dot org
@ 2005-06-13 19:20 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:22 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:23 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-13 19:20 UTC (permalink / raw)
To: java-prs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-13 19:20 -------
Subject: Bug 21844
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: tromey@gcc.gnu.org 2005-06-13 19:20:26
Modified files:
gcc/java : ChangeLog parse.y
Log message:
PR java/21844:
* parse.y (nested_field_access_p): Handle case where outer field
is inherited by enclosing class.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1626&r2=1.1627
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.538&r2=1.539
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (7 preceding siblings ...)
2005-06-13 19:20 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-13 19:22 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:23 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-13 19:22 UTC (permalink / raw)
To: java-prs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-13 19:22 -------
Subject: Bug 21844
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: tromey@gcc.gnu.org 2005-06-13 19:21:56
Modified files:
libjava : ChangeLog
Added files:
libjava/testsuite/libjava.lang: pr21844.java pr21844.out
Log message:
PR java/21844:
* testsuite/libjava.lang/pr21844.java: New file.
* testsuite/libjava.lang/pr21844.out: New file.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3658&r2=1.3659
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr21844.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/pr21844.out.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
` (8 preceding siblings ...)
2005-06-13 19:22 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-13 19:23 ` tromey at gcc dot gnu dot org
9 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2005-06-13 19:23 UTC (permalink / raw)
To: java-prs
------- Additional Comments From tromey at gcc dot gnu dot org 2005-06-13 19:23 -------
I've checked in the fix.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
[not found] <bug-21844-360@http.gcc.gnu.org/bugzilla/>
2005-10-05 19:35 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-05 19:40 ` pinskia at gcc dot gnu dot org
1 sibling, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-10-05 19:40 UTC (permalink / raw)
To: java-prs
------- Comment #12 from pinskia at gcc dot gnu dot org 2005-10-05 19:40 -------
Also fixed in 4.0.3.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.1.0 |4.0.3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug java/21844] [4.1 Regression] miscompilation of LinkedHashMap
[not found] <bug-21844-360@http.gcc.gnu.org/bugzilla/>
@ 2005-10-05 19:35 ` cvs-commit at gcc dot gnu dot org
2005-10-05 19:40 ` pinskia at gcc dot gnu dot org
1 sibling, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-05 19:35 UTC (permalink / raw)
To: java-prs
------- Comment #11 from cvs-commit at gcc dot gnu dot org 2005-10-05 19:35 -------
Subject: Bug 21844
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: bryce@gcc.gnu.org 2005-10-05 19:35:46
Modified files:
gcc/java : ChangeLog decl.c java-tree.h jcf-write.c
parse.y
libjava : ChangeLog
libjava/testsuite/libjava.jacks: jacks.xfail
Added files:
libjava/testsuite/libjava.lang: PR19870.java PR19870.out
PR19870_2.java PR19870_2.out
Log message:
gcc/java:
2005-10-05 Ranjit Mathew <rmathew@hotmail.com>
PR java/20338
* decl.c (finish_method): Emit _Jv_InitClass for private static
methods inside inner classes as well.
2005-10-05 Ranjit Mathew <rmathew@hotmail.com>
PR java/19870
* parse.y (nested_field_access_p): Rename to nested_member_access_p
and expand to handle method accesses across nested classes.
(build_outer_method_access_method): Rename to
build_nested_method_access_method. Minor adjustments to comments.
(resolve_expression_name): Use the newly-renamed
nested_member_access_p method.
(resolve_qualified_expression_name): Likewise.
(patch_method_invocation): Also consider static methods for access
method generation. Minor adjustments to comments.
(maybe_use_access_method): Use the more general
nested_memeber_access_p to determine access across nested class
boundaries. Allow THIS_ARG to be NULL (for static methods).
2005-10-05 Tom Tromey <tromey@redhat.com>
PR java/21844:
* parse.y (nested_field_access_p): Handle case where outer field
is inherited by enclosing class.
2005-10-05 Ranjit Mathew <rmathew@hotmail.com>
PR java/19870.
* java-tree.h (OUTER_FIELD_ACCESS_IDENTIFIER_P): Rename to
NESTED_FIELD_ACCESS_IDENTIFIER_P.
(FIELD_INNER_ACCESS): Rename to FIELD_NESTED_ACCESS.
(FIELD_INNER_ACCESS_P): Rename to FIELD_NESTED_ACCESS_P.
* jcf-write.c (generate_classfile): Use
NESTED_FIELD_ACCESS_IDENTIFIER_P instead of
OUTER_FIELD_ACCESS_IDENTIFIER_P.
* parse.y (build_outer_field_access): Rename to
build_nested_field_access. Support static fields and outer-to-inner
class accesses.
(outer_field_access_p): Rename to nested_field_access_p. Support
static fields and generalise to outer-to-inner class and sibling
inner class accesses.
(outer_field_expanded_access_p): Rename to
nested_field_expanded_access_p and support static fields.
(outer_field_access_fix): Rename to nested_field_access_fix and
support static fields.
(build_outer_field_access_expr): Rename to
build_nested_field_access_expr and support static fields.
(build_outer_field_access_methods): Rename to
build_nested_field_access_methods and support static fields. For
static fields, generate accessors without class instance parameters.
(build_outer_field_access_method): Rename to
build_nested_field_access_method and support static fields.
(build_outer_method_access_method): Use
NESTED_FIELD_ACCESS_IDENTIFIER_P instead of
OUTER_FIELD_ACCESS_IDENTIFIER_P.
(resolve_expression_name): Consider static field accesses across
nested classes.
(resolve_qualified_expression_name): Likewise.
(java_complete_lhs): Use nested_field_access_fix instead of
outer_field_access_fix.
(patch_unary_op): Rename outer_field_flag to nested_field_flag.
Use nested_field_expanded_access_p instead of
outer_field_expanded_access_p. Use nested_field_access_fix instead
of outer_field_access_fix.
(check_thrown_exceptions): Use NESTED_FIELD_ACCESS_IDENTIFIER_P
instead of OUTER_FIELD_ACCESS_IDENTIFIER_P.
libjava:
2005-10-05 Ranjit Mathew <rmathew@hotmail.com>
More testsuite adjustments for PR java/19870.
* testsuite/libjava.lang/PR19870_2.java: New testcase.
* testsuite/libjava.lang/PR19870_2.out: Expected output for the
new testcase.
* testsuite/libjava.jacks/jacks.xfail: Remove
8.5.2-non-static-member-usage-2 and add
15.12.3-explicit-constructor-9.
2005-10-05 Tom Tromey <tromey@redhat.com>
PR java/21844:
* testsuite/libjava.lang/pr21844.java: New file.
* testsuite/libjava.lang/pr21844.out: New file.
2005-10-05 Ranjit Mathew <rmathew@hotmail.com>
Testsuite adjustments for PR java/19870.
* testsuite/libjava.lang/PR19870.java: New testcase.
* testsuite/libjava.lang/PR19870.out: Expected output for the
testcase.
* testsuite/libjava.jacks/jacks.xfail: Add
8.5.2-accessible-static-member-usage-3 and 15.8.4-static-2
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1556.2.34&r2=1.1556.2.35
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/decl.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.209.4.4&r2=1.209.4.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/java-tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.226.8.3&r2=1.226.8.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/jcf-write.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.162.4.1&r2=1.162.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.528.6.4&r2=1.528.6.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.103&r2=1.3391.2.104
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.jacks/jacks.xfail.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.19.8.2&r2=1.19.8.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR19870.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.24.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR19870.out.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.24.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR19870_2.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.18.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR19870_2.out.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.18.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21844
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2005-10-05 19:40 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-31 18:07 [Bug java/21844] New: miscompilation of LinkedHashMap tromey at gcc dot gnu dot org
2005-06-03 20:02 ` [Bug java/21844] " tromey at gcc dot gnu dot org
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
2005-06-03 20:03 ` tromey at gcc dot gnu dot org
2005-06-03 20:11 ` pinskia at gcc dot gnu dot org
2005-06-03 20:14 ` [Bug java/21844] [4.1 Regression] " pinskia at gcc dot gnu dot org
2005-06-03 21:18 ` tromey at gcc dot gnu dot org
2005-06-03 22:03 ` tromey at gcc dot gnu dot org
2005-06-13 19:20 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:22 ` cvs-commit at gcc dot gnu dot org
2005-06-13 19:23 ` tromey at gcc dot gnu dot org
[not found] <bug-21844-360@http.gcc.gnu.org/bugzilla/>
2005-10-05 19:35 ` cvs-commit at gcc dot gnu dot org
2005-10-05 19:40 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).