[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-24 21:49 -------
FWIW I agree with the analysis.
This is related to PR 21540, but not the same.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-27 16:52 -------
The problem here is that the code in patch_binop that
converts URSHIFT_EXPR to RSHIFT_EXPR modifies the type and
code of the tree in place -- but that is incorrect as it misses
the final cast back to a signed type.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-27 16:59 -------
I'm testing a fix.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-05-21 12:55:00         |2005-06-27 16:59:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-06-27 18:40 -------
Subject: Bug 13788

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-06-27 18:40:17

Modified files:
	libjava        : ChangeLog 
	gcc/java       : ChangeLog parse.y 
	libjava/testsuite/libjava.jacks: jacks.xfail 
Added files:
	libjava/testsuite/libjava.compile: pr13788.java pr21540.java 

Log message:
	gcc/java/:
	PR java/21540, PR java/13788:
	* parse.y (java_complete_lhs) <CASE_EXPR>: Use
	fold_constant_for_init.
	(patch_binop): Added 'folding' argument.  Updated all callers.
	(patch_unaryop) <NOP_EXPR>: New case.
	(fold_constant_for_init) <NOP_EXPR>: Likewise.
	(fold_constant_for_init) <COND_EXPR>: Fix sense of test.
	libjava/:
	PR java/21540, PR java/13788:
	* testsuite/libjava.compile/pr21540.java: New file.
	* testsuite/libjava.compile/pr13788.java: New file.
	* testsuite/libjava.jacks/jacks.xfail: Updated.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3679&r2=1.3680
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1634&r2=1.1635
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.541&r2=1.542
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.compile/pr13788.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.compile/pr21540.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.jacks/jacks.xfail.diff?cvsroot=gcc&r1=1.24&r2=1.25



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-06-27 18:41 -------
I checked this in to cvs trunk.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[mckinlay at redhat dot com]

------- Comment #9 from mckinlay at redhat dot com  2005-10-13 01:14 -------
Fixed checked in to 4.0 branch.


-- 

mckinlay at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788

[Bug java/13788] Zero propogate right shift in static final int initializer causes error

[cvs-commit at gcc dot gnu dot org]

------- Comment #8 from cvs-commit at gcc dot gnu dot org  2005-10-13 01:11 -------
Subject: Bug 13788

CVSROOT:        /cvs/gcc
Module name:    gcc
Branch:         gcc-4_0-branch
Changes by:     bryce@gcc.gnu.org       2005-10-13 01:11:27

Modified files:
        gcc/java       : ChangeLog parse.y 
        libjava        : ChangeLog 
        libjava/testsuite/libjava.jacks: jacks.xfail 
Added files:
        libjava/testsuite/libjava.compile: pr13788.java pr21540.java 

Log message:
        gcc/java:
        2005-10-12  Tom Tromey  <tromey@redhat.com>

        PR java/21540, PR java/13788:
        * parse.y (java_complete_lhs) <CASE_EXPR>: Use
        fold_constant_for_init.
        (patch_binop): Added 'folding' argument.  Updated all callers.
        (patch_unaryop) <NOP_EXPR>: New case.
        (fold_constant_for_init) <NOP_EXPR>: Likewise.
        (fold_constant_for_init) <COND_EXPR>: Fix sense of test.

        libjava:
        2005-10-12  Andreas Tobler  <a.tobler@schweiz.ch>

        * testsuite/libjava.jacks/jacks.xfail: Remove 15.21-assoc-7,
        15.21-assoc-8, 15.21-equal-3, 15.28-string-11.

        2005-10-12  Tom Tromey  <tromey@redhat.com>

        PR java/21540, PR java/13788:
        * testsuite/libjava.compile/pr21540.java: New file.
        * testsuite/libjava.compile/pr13788.java: New file.
        * testsuite/libjava.jacks/jacks.xfail: Updated.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1556.2.35&r2=1.1556.2.36
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.528.6.5&r2=1.528.6.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.105&r2=1.3391.2.106
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.compile/pr13788.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.22.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.compile/pr21540.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.22.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.jacks/jacks.xfail.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.19.8.3&r2=1.19.8.4


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13788