[Bug SWING/22567] New: JCheckBox's check box is missing

[Bug SWING/22567] New: JCheckBox's check box is missing

[timo dot lindfors at iki dot fi]

Steps to reproduce:
1. Compile and run the attached testcase.

Expected results:
1. A window with a check box and "text1" shows up.

Actual results:
1. A window with "text1" shows up. No check box is visible.

Testcase:
import java.awt.*;
import javax.swing.*;

public class testcase extends JFrame {
        public static void main(String[] args) {
                new testcase().show();
        }
        public testcase() {
                JCheckBox checkbox = new JCheckBox("text1" , true);
                setContentPane(checkbox);
                setSize(new Dimension(300, 300));
        }
}

The check box is visible with gnu classpath cvs 2005-07-15T11:38:00+0000 but
missing with gnu classpath cvs 2005-07-15T11:45:00+0000. Diff between these
versions shows the following changelog entry:

+2005-07-15  Roman Kennke  <roman@kennke.org>
+
+       * javax/swing/AbstractButton.java
+       (AbstractButton): Directly call init() and updateUI().
+       (AbstractButton(String, Icon)): Removed. This is not necessary
+       since we have init(String, Icon) for that purpose.
+       (getActionCommand): Reverted to previous behaviour: If
+       actionCommand is set, return this, otherwise return text, even
+       if text is null.
+       * javax/swing/JButton.java
+       (JButton(String, Icon)): Call super() and init(String, Icon)
+       instead of super(String, Icon).
+       * javax/swing/JMenuItem.java
+       (JMenuItem): Call super() instead of super(String, Icon).
+       (JMenuItem(Icon)): Call this(String, Icon) instead of
+       super(String, Icon).
+       (JMenuItem(String)): Call this(String, Icon) instead of
+       super(String, Icon).
+       (JMenuItem(Action)): Call super() instead of
+       super(String, Icon).
+       (JMenuItem(String, Icon)): Call super() and init(String, Icon)
+       instead of super(String, Icon).
+       (JMenuItem(String, int)): Call this(String, Icon) instead of
+       super(String, Icon).
+       * javax/swing/JToggleButton.java
+       (ToggleButtonModel.setPressed): Fire an ActionEvent if button
+       is released. According to my Mauve tests, it seems that this
+       is what the JDK does, so do we.
+       (ToggleButtonModel.setSelected): Removed.
+       (JToggleButton): Call super() and init(String, Icon) instead
+       of super(String, Icon).
+

-- 
           Summary: JCheckBox's check box is missing
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: SWING
        AssignedTo: graydon at redhat dot com
        ReportedBy: timo dot lindfors at iki dot fi
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug SWING/22567] JCheckBox's check box is missing

[roman at kennke dot org]

------- Additional Comments From roman at kennke dot org  2005-07-20 19:26 -------
I'll take care if this. I already checked in the icon that should display the
CheckBox in the MetalLookAndFeel, now it only needs to get wired to the actual
CheckBox. Note that there is no CheckBox icon in the BasicLookAndFeel for
JCheckBox. Someone with the proper permissions could assign this bug to me, set
it to CONFIRMED and give me some more permissions please? ;-)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug SWING/22567] JCheckBox's check box is missing

[fitzsim at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|graydon at redhat dot com   |roman at kennke dot org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-20 19:50:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug SWING/22567] JCheckBox's check box is missing

[roman at kennke dot org]

------- Additional Comments From roman at kennke dot org  2005-07-21 12:11 -------
I fixed this in Classpath. This should be merged in and this bugreport closed.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug swing/22567] JCheckBox's check box is missing

[timo dot lindfors at iki dot fi]

------- Additional Comments From timo dot lindfors at iki dot fi  2005-07-25 14:02 -------
Actual results have changed between builds 2005-07-22T100134+0000 and
2005-07-23T221620+0000. Now the output is:

java.lang.NullPointerException
   at gnu.java.awt.peer.gtk.GdkFontMetrics.<init> (GdkFontMetrics.java:69)
   at gnu.java.awt.peer.gtk.GtkToolkit.getFontMetrics (GtkToolkit.java:350)
   at javax.swing.plaf.basic.BasicGraphicsUtils.getPreferredButtonSize
(BasicGraphicsUtils.java:612)
   at javax.swing.plaf.basic.BasicButtonUI.getPreferredSize
(BasicButtonUI.java:212)
   at javax.swing.JComponent.getPreferredSize (JComponent.java:1029)
   at javax.swing.JRootPane$RootLayout.preferredLayoutSize (JRootPane.java:278)
   at java.awt.Container.preferredSize (Container.java:626)
   at java.awt.Container.getPreferredSize (Container.java:613)
   at javax.swing.JComponent.getPreferredSize (JComponent.java:1035)
   at java.awt.BorderLayout.calcCompSize (BorderLayout.java:655)
   at java.awt.BorderLayout.calcSize (BorderLayout.java:700)
   at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
   at java.awt.Container.preferredSize (Container.java:626)
   at java.awt.Container.getPreferredSize (Container.java:613)
   at javax.swing.JFrame.getPreferredSize (JFrame.java:136)
   at java.awt.Window.pack (Window.java:267)
   at testcase.<init> (testcase.java:12)
   at testcase.main (testcase.java:6)



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug swing/22567] JCheckBox's check box is missing

[roman at kennke dot org]

------- Additional Comments From roman at kennke dot org  2005-07-25 14:17 -------
Whoops, this was an accident. I don't really know why the Gtk peers can't cope
with that. I checked in a fix for that.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug swing/22567] JCheckBox's check box is missing

[timo dot lindfors at iki dot fi]

------- Additional Comments From timo dot lindfors at iki dot fi  2005-07-25 14:45 -------
The testcase works flawlessly now, thanks!

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567

[Bug swing/22567] JCheckBox's check box is missing

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |0.18


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22567