[Bug java/23292] New: libjava build fails with recent version of GNU Make

[Bug java/23292] New: libjava build fails with recent version of GNU Make

[matria at gmail dot com]

The latest beta of GNU Make (3.81beta3) introduced `secondary expansions',
performed on all prerequisites of all targets. This breaks the Makefile in the
`libjava' directory because the `$$' in the `inner_nat_headers' variable are
expanded twice. The following fixed it for me:

--- Makefile.am 2005-04-27 21:34:20.000000000 -0400
+++ Makefile.am.fixed   2005-08-08 16:11:45.599005993 -0400
@@ -727,7 +727,7 @@
     $(ordinary_java_source_files:.java=.h) \
     $(built_java_source_files:.java=.h)

-inner_nat_headers = java/io/ObjectOutputStream$$PutField.h \
+_inner_nat_headers = java/io/ObjectOutputStream$$PutField.h \
        java/io/ObjectInputStream$$GetField.h \
        java/nio/DirectByteBufferImpl$$ReadWrite.h \
        java/nio/channels/Pipe$$SinkChannel.h \
@@ -740,6 +740,12 @@
        gnu/java/nio/PipeImpl$$SourceChannelImpl.h \
        $(PLATFORM_INNER_NAT_HDRS)

+ifeq ($(findstring second-expansion,$(.FEATURES)),)
+  inner_nat_headers = $(_inner_nat_headers)
+else
+  inner_nat_headers = $$(_inner_nat_headers)
+endif
+
 nat_headers = $(ordinary_nat_headers) $(inner_nat_headers)
gnu/gcj/tools/gcj_dbtool/Main.h
 nat_headers_install = $(ordinary_nat_headers)

-- 
           Summary: libjava build fails with recent version of GNU Make
           Product: gcc
           Version: 4.0.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: matria at gmail dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-11 13:53 -------
This seems like a bug in GNU make and should reported there instead as it could cause other issues.  
Seems like this should be turned off by default and have a way to turn it on for these makefiles who 
wants it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|java                        |libgcj


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-08-12 18:42 -------
Although this is fairly ugly, I'm not opposed to it.
I am however a bit reluctant to check in a patch to work around
a feature in a beta version of make.  It seems to me that perhaps
a feature that causes problems like this might be removed before
a final release... ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2005-11-24 04:50 -------
GNU make is changing so there is no reason for this bug to be opened any more.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2005-10-09 20:00 -------
Just for future references I wrote something in:
http://savannah.gnu.org/bugs/index.php?func=detailitem&item_id=13781

Complaining about the situational.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-10-09 19:36 -------
Note this will cause problems more with java than it does with any other
language since $ is normal in class files as it is used for inner classes.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-10-09 19:34 -------
Can you guys really report this to GNU make and say that this should not
change.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292

[Bug libgcj/23292] libjava build fails with recent version of GNU Make

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2005-10-09 19:33 -------
*** Bug 24289 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bero at arklinux dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23292