public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
From: "wmahan at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug fastjar/13020] zip-style comments
Date: Sun, 28 Aug 2005 22:18:00 -0000 [thread overview]
Message-ID: <20050828221829.19399.qmail@sourceware.org> (raw)
In-Reply-To: <20031112105339.13020.swhite@decisionsoft.com>
------- Additional Comments From wmahan at gmail dot com 2005-08-28 22:18 -------
Hi, I submitted a different patch to the upstream FastJar sources at
http://sourceforge.net/tracker/index.php?func=detail&aid=1275036&group_id=426&atid=300426
before I noticed this bug. (It doesn't apply to the gcc tree, but it would be
simple to make a patch if desired.)
When a zip-style comment is present, the patch by Stephen White searches
backwards from the end for the central-header-end section to read the offset of
the central header, while my patch parses through the file from the beginning to
find the central header.
Either approach should fix the problem. My fix might be a little less efficient,
but I think Stephen's patch would fail if the comment happens to contain the
magic string 0x06054b50. I'm not sure if that ever happens in practice.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020
next prev parent reply other threads:[~2005-08-28 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031112105339.13020.swhite@decisionsoft.com>
2005-05-30 15:34 ` pinskia at gcc dot gnu dot org
2005-08-28 22:18 ` wmahan at gmail dot com [this message]
2005-08-29 4:54 ` pinskia at gcc dot gnu dot org
[not found] <bug-13020-7352@http.gcc.gnu.org/bugzilla/>
2006-04-22 20:58 ` pinskia at gcc dot gnu dot org
2007-02-12 23:47 ` robilad at kaffe dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050828221829.19399.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=java-prs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).