public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
* [Bug java/25847] New: libjava build doesn't stop when there is a fatal error @ 2006-01-18 18:57 hjl at lucon dot org 2006-01-18 19:00 ` [Bug java/25847] " pinskia at gcc dot gnu dot org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: hjl at lucon dot org @ 2006-01-18 18:57 UTC (permalink / raw) To: java-prs While investigating PR 25840, I notice that when there is a fatal error during libjava build, build doesn't stop. I found this in my build log: creating gcj-dbtool ./gcj-dbtool -n classmap.db || touch classmap.db creating gij /bin/sh: line 1: 17842 Segmentation fault ./gcj-dbtool -n classmap.db make[5]: Leaving directory `/export/build/gnu/gcc-next/build-x86_64-linux/x86_64-unknown-linux-gnu/libjava' The problem is in libjava/Makefile.am: ## The .db file. This rule is only used for native builds, so it is ## safe to invoke gcj-dbtool. $(db_name): gcj-dbtool$(EXEEXT) ## In case it exists already. @rm -f $(db_name) ## We don't actually care if it fails -- if it does, just make an ## empty file. This is simpler than trying to discover when mmap is ## not available. ./gcj-dbtool -n $(db_name) || touch $(db_name) -- Summary: libjava build doesn't stop when there is a fatal error Product: gcc Version: 4.2.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: java AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: hjl at lucon dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25847 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug java/25847] libjava build doesn't stop when there is a fatal error 2006-01-18 18:57 [Bug java/25847] New: libjava build doesn't stop when there is a fatal error hjl at lucon dot org @ 2006-01-18 19:00 ` pinskia at gcc dot gnu dot org 2006-01-18 19:14 ` hjl at lucon dot org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu dot org @ 2006-01-18 19:00 UTC (permalink / raw) To: java-prs ------- Comment #1 from pinskia at gcc dot gnu dot org 2006-01-18 19:00 ------- Lets look: ## We don't actually care if it fails -- if it does, just make an ## empty file. This is simpler than trying to discover when mmap is ## not available. so what is the problem here? This is not really a major failure really. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25847 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug java/25847] libjava build doesn't stop when there is a fatal error 2006-01-18 18:57 [Bug java/25847] New: libjava build doesn't stop when there is a fatal error hjl at lucon dot org 2006-01-18 19:00 ` [Bug java/25847] " pinskia at gcc dot gnu dot org @ 2006-01-18 19:14 ` hjl at lucon dot org 2006-03-31 23:30 ` tromey at gcc dot gnu dot org 2006-04-05 19:14 ` pinskia at gcc dot gnu dot org 3 siblings, 0 replies; 5+ messages in thread From: hjl at lucon dot org @ 2006-01-18 19:14 UTC (permalink / raw) To: java-prs ------- Comment #2 from hjl at lucon dot org 2006-01-18 19:14 ------- It depends on what kind of failure. This "Segmentation fault" is due to a broken libgcj.so. It makes no senses to continue. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25847 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug java/25847] libjava build doesn't stop when there is a fatal error 2006-01-18 18:57 [Bug java/25847] New: libjava build doesn't stop when there is a fatal error hjl at lucon dot org 2006-01-18 19:00 ` [Bug java/25847] " pinskia at gcc dot gnu dot org 2006-01-18 19:14 ` hjl at lucon dot org @ 2006-03-31 23:30 ` tromey at gcc dot gnu dot org 2006-04-05 19:14 ` pinskia at gcc dot gnu dot org 3 siblings, 0 replies; 5+ messages in thread From: tromey at gcc dot gnu dot org @ 2006-03-31 23:30 UTC (permalink / raw) To: java-prs ------- Comment #3 from tromey at gcc dot gnu dot org 2006-03-31 23:30 ------- Is there a reasonable way to detect good failures versus bad failures here? We definitely want to ignore cases where gcj-dbtool fails due to things like not having mmap available. Perhaps the thing to do is let it fail and then catch it during 'make check'. -- tromey at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tromey at gcc dot gnu dot | |org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25847 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug java/25847] libjava build doesn't stop when there is a fatal error 2006-01-18 18:57 [Bug java/25847] New: libjava build doesn't stop when there is a fatal error hjl at lucon dot org ` (2 preceding siblings ...) 2006-03-31 23:30 ` tromey at gcc dot gnu dot org @ 2006-04-05 19:14 ` pinskia at gcc dot gnu dot org 3 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu dot org @ 2006-04-05 19:14 UTC (permalink / raw) To: java-prs ------- Comment #4 from pinskia at gcc dot gnu dot org 2006-04-05 19:14 ------- Always do a make check, this is the correct thing to do when checking the compiler anyways. -- pinskia at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25847 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-04-05 19:14 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2006-01-18 18:57 [Bug java/25847] New: libjava build doesn't stop when there is a fatal error hjl at lucon dot org 2006-01-18 19:00 ` [Bug java/25847] " pinskia at gcc dot gnu dot org 2006-01-18 19:14 ` hjl at lucon dot org 2006-03-31 23:30 ` tromey at gcc dot gnu dot org 2006-04-05 19:14 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).