* [Bug libgcj/27860] [4.2 Regression] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
@ 2006-06-02 2:25 ` pinskia at gcc dot gnu dot org
2006-06-02 2:26 ` [Bug libgcj/27860] " pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-02 2:25 UTC (permalink / raw)
To: java-prs
------- Comment #3 from pinskia at gcc dot gnu dot org 2006-06-02 02:25 -------
(In reply to comment #2)
> I'm CCing Andreas Schwab since he apparently ported ffi to m68k. I noticed
> that the part of the code that produces the error is within an ifdef
> USE_LIBFFI, so possibly disabling ffi on m68k would allow it to compile. But
> maybe the real fix would be to update ffi on m68k or something. Maybe Andreas
> can take a look and/or comment.
libffi should work on m68k. It might be closures have not been ported to m68k
which means INTERPRETER should be false. (This is all from memory).
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |java-prs at gcc dot gnu dot
| |org
Summary|build failure on m68k: |[4.2 Regression] build
|error: 'ffi_closure' does |failure on m68k: error:
|not name a type |'ffi_closure' does not name
| |a type
Target Milestone|--- |4.2.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
2006-06-02 2:25 ` [Bug libgcj/27860] [4.2 Regression] build failure on m68k: error: 'ffi_closure' does not name a type pinskia at gcc dot gnu dot org
@ 2006-06-02 2:26 ` pinskia at gcc dot gnu dot org
2006-06-04 18:35 ` schwab at suse dot de
` (9 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-02 2:26 UTC (permalink / raw)
To: java-prs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.2 Regression] build |build failure on m68k:
|failure on m68k: error: |error: 'ffi_closure' does
|'ffi_closure' does not name |not name a type
|a type |
Target Milestone|4.2.0 |---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
2006-06-02 2:25 ` [Bug libgcj/27860] [4.2 Regression] build failure on m68k: error: 'ffi_closure' does not name a type pinskia at gcc dot gnu dot org
2006-06-02 2:26 ` [Bug libgcj/27860] " pinskia at gcc dot gnu dot org
@ 2006-06-04 18:35 ` schwab at suse dot de
2006-06-05 14:08 ` tromey at gcc dot gnu dot org
` (8 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: schwab at suse dot de @ 2006-06-04 18:35 UTC (permalink / raw)
To: java-prs
------- Comment #4 from schwab at suse dot de 2006-06-04 18:35 -------
Only the error reporting needs support for closures, the other use of libffi in
libgcj should work fine as long as libffi works, I think.
--
schwab at suse dot de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at redhat dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2006-06-04 18:35 ` schwab at suse dot de
@ 2006-06-05 14:08 ` tromey at gcc dot gnu dot org
2006-06-05 15:03 ` schwab at suse dot de
` (7 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: tromey at gcc dot gnu dot org @ 2006-06-05 14:08 UTC (permalink / raw)
To: java-prs
------- Comment #5 from tromey at gcc dot gnu dot org 2006-06-05 14:08 -------
It looks to me that the code in link.cc is testing the wrong define.
It is testing USE_LIBFFI, but that is defined if any part of libffi is
in use. Instead it should be testing INTERPRETER -- ideally we'd add
a new macro indicating whether libffi has the closure API ported, as
INTERPRETER catches a bit too much.
Could you try changing USE_LIBFFI to INTERPRETER in link.cc? There are
a few places to change. If that fixes the problem for you, we can check
it in.
--
tromey at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-06-05 14:08:20
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2006-06-05 14:08 ` tromey at gcc dot gnu dot org
@ 2006-06-05 15:03 ` schwab at suse dot de
2006-06-05 18:58 ` tbm at cyrius dot com
` (6 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: schwab at suse dot de @ 2006-06-05 15:03 UTC (permalink / raw)
To: java-prs
------- Comment #6 from schwab at suse dot de 2006-06-05 15:03 -------
ffitarget.h already provides a macro for closure support: FFI_CLOSURES. Does
this patch makes sense?
Index: link.cc
===================================================================
--- link.cc (revision 114359)
+++ link.cc (working copy)
@@ -788,7 +788,7 @@ _Jv_ThrowNoSuchMethodError ()
throw new java::lang::NoSuchMethodError;
}
-#ifdef USE_LIBFFI
+#if defined USE_LIBFFI && FFI_CLOSURES
// A function whose invocation is prepared using libffi. It gets called
// whenever a static method of a missing class is invoked. The data argument
// holds a reference to a String denoting the missing class.
@@ -974,7 +974,7 @@ _Jv_Linker::find_iindex (jclass *ifaces,
return i;
}
-#ifdef USE_LIBFFI
+#if defined USE_LIBFFI && FFI_CLOSURES
// We use a structure of this type to store the closure that
// represents a missing method.
struct method_closure
@@ -1027,7 +1027,7 @@ _Jv_Linker::create_error_method (_Jv_Utf
// of the missing class then.
return (void *) _Jv_ThrowNoClassDefFoundError;
}
-#endif // USE_LIBFFI
+#endif // USE_LIBFFI && FFI_CLOSURES
// Functions for indirect dispatch (symbolic virtual binding) support.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2006-06-05 15:03 ` schwab at suse dot de
@ 2006-06-05 18:58 ` tbm at cyrius dot com
2006-06-05 19:05 ` schwab at suse dot de
` (5 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: tbm at cyrius dot com @ 2006-06-05 18:58 UTC (permalink / raw)
To: java-prs
------- Comment #7 from tbm at cyrius dot com 2006-06-05 18:58 -------
Thanks, Andreas. The file compiles with this patch. But now it fails a little
bit later:
gnu/java/net/natPlainDatagramSocketImpl.cc: In member function 'virtual void
gnu::java::net::PlainDatagramSocketImpl::receive(java::net::DatagramPacket*)':
gnu/java/net/natPlainDatagramSocketImpl.cc:351: error: impossible constraint in
'asm'
make[1]: *** [gnu/java/net/natPlainDatagramSocketImpl.lo] Error 1
any idea?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2006-06-05 18:58 ` tbm at cyrius dot com
@ 2006-06-05 19:05 ` schwab at suse dot de
2006-06-05 19:59 ` tromey at gcc dot gnu dot org
` (4 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: schwab at suse dot de @ 2006-06-05 19:05 UTC (permalink / raw)
To: java-prs
------- Comment #8 from schwab at suse dot de 2006-06-05 19:05 -------
I don't see that here. You are probably using the wrong glibc headers. There
is no asm in FD_ZERO for m68k.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2006-06-05 19:05 ` schwab at suse dot de
@ 2006-06-05 19:59 ` tromey at gcc dot gnu dot org
2006-06-05 20:02 ` tbm at cyrius dot com
` (3 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: tromey at gcc dot gnu dot org @ 2006-06-05 19:59 UTC (permalink / raw)
To: java-prs
------- Comment #9 from tromey at gcc dot gnu dot org 2006-06-05 19:59 -------
Andreas -- yes, that patch looks good to me.
Please check it in. Thanks!
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2006-06-05 19:59 ` tromey at gcc dot gnu dot org
@ 2006-06-05 20:02 ` tbm at cyrius dot com
2006-06-05 20:45 ` tbm at cyrius dot com
` (2 subsequent siblings)
11 siblings, 0 replies; 12+ messages in thread
From: tbm at cyrius dot com @ 2006-06-05 20:02 UTC (permalink / raw)
To: java-prs
------- Comment #10 from tbm at cyrius dot com 2006-06-05 20:02 -------
(In reply to comment #8)
> I don't see that here. You are probably using the wrong glibc headers. There
> is no asm in FD_ZERO for m68k.
For some reason, /usr/include got included even though I'm cross-compiling.
Anyway, I removed that and it's building. I'll let you know if there's another
problem later on but so far it looks good.
Thanks for your patch!
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2006-06-05 20:02 ` tbm at cyrius dot com
@ 2006-06-05 20:45 ` tbm at cyrius dot com
2006-06-05 21:21 ` schwab at gcc dot gnu dot org
2006-06-05 21:36 ` schwab at suse dot de
11 siblings, 0 replies; 12+ messages in thread
From: tbm at cyrius dot com @ 2006-06-05 20:45 UTC (permalink / raw)
To: java-prs
------- Comment #11 from tbm at cyrius dot com 2006-06-05 20:45 -------
It has built successfully.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2006-06-05 20:45 ` tbm at cyrius dot com
@ 2006-06-05 21:21 ` schwab at gcc dot gnu dot org
2006-06-05 21:36 ` schwab at suse dot de
11 siblings, 0 replies; 12+ messages in thread
From: schwab at gcc dot gnu dot org @ 2006-06-05 21:21 UTC (permalink / raw)
To: java-prs
------- Comment #12 from schwab at gcc dot gnu dot org 2006-06-05 21:21 -------
Subject: Bug 27860
Author: schwab
Date: Mon Jun 5 21:21:05 2006
New Revision: 114411
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114411
Log:
PR libgcj/27860
* link.cc: Check for closure support in libffi with FFI_CLOSURES.
Modified:
trunk/libjava/ChangeLog
trunk/libjava/link.cc
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug libgcj/27860] build failure on m68k: error: 'ffi_closure' does not name a type
[not found] <bug-27860-12387@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2006-06-05 21:21 ` schwab at gcc dot gnu dot org
@ 2006-06-05 21:36 ` schwab at suse dot de
11 siblings, 0 replies; 12+ messages in thread
From: schwab at suse dot de @ 2006-06-05 21:36 UTC (permalink / raw)
To: java-prs
------- Comment #13 from schwab at suse dot de 2006-06-05 21:36 -------
Fixed.
--
schwab at suse dot de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27860
^ permalink raw reply [flat|nested] 12+ messages in thread