[Bug libgcj/29362] New: NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[Bug libgcj/29362] New: NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[jjohnstn at redhat dot com]

The new FC6 eclipse cdt generates a java.lang.NullPointerException everytime it
tries to save the .cdtproject project file.  This occurs when changes are made
to a CDT project.  For example, adding a new source folder causes the error.

I have isolated the problem to a stand-alone testcase which reads in a current
.cdtproject file to prime the information, then goes about the actions taken by
the save call.

-bash-3.1$ java CDescription
Exception in thread "main" java.lang.NullPointerException
   at gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)
   at gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)
   at gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)
   at gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)
   at gnu.xml.transform.TransformerImpl.transform(libgcj.so.7rh)
   at CDescription.getAsXml(CDescription.java:93)
   at CDescription.run(CDescription.java:99)
   at CDescription.main(CDescription.java:113)


-- 
           Summary: NullPointerException in
                    gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)
           Product: gcc
           Version: 4.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jjohnstn at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug libgcj/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[jjohnstn at redhat dot com]

------- Comment #1 from jjohnstn at redhat dot com  2006-10-05 20:48 -------
Created an attachment (id=12386)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12386&action=view)
Testcase that exhibits problem


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug libgcj/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[jjohnstn at redhat dot com]

------- Comment #2 from jjohnstn at redhat dot com  2006-10-05 21:12 -------
Created an attachment (id=12387)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12387&action=view)
sample cdtproject file that is used by test case


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[mark at gcc dot gnu dot org]

------- Comment #3 from mark at gcc dot gnu dot org  2006-10-05 22:01 -------
Confirmed with classpath CVS:

$ /usr/local/jamvm/bin/jamvm CDescription
java.lang.NullPointerException
   at gnu.xml.transform.TransformerImpl.strip(TransformerImpl.java:452)
   at gnu.xml.transform.TransformerImpl.strip(TransformerImpl.java:459)
   at gnu.xml.transform.TransformerImpl.strip(TransformerImpl.java:459)
   at gnu.xml.transform.TransformerImpl.strip(TransformerImpl.java:459)
   at gnu.xml.transform.TransformerImpl.transform(TransformerImpl.java:330)
   at CDescription.getAsXml(CDescription.java:93)
   at CDescription.run(CDescription.java:99)
   at CDescription.main(CDescription.java:113)


-- 

mark at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|libgcj                      |xml
     Ever Confirmed|0                           |1
            Product|gcc                         |classpath
   Last reconfirmed|0000-00-00 00:00:00         |2006-10-05 22:01:37
               date|                            |
            Version|4.1.1                       |unspecified


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[tromey at gcc dot gnu dot org]

------- Comment #4 from tromey at gcc dot gnu dot org  2006-10-05 22:03 -------
Also happens with gcc svn head.
I was also going to CC dog :)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[tromey at gcc dot gnu dot org]

------- Comment #5 from tromey at gcc dot gnu dot org  2006-10-06 19:21 -------
Created an attachment (id=12391)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12391&action=view)
proposed patch

This patch makes the crash go away.

The bug is that strip() unconditionally uses 'stylesheet', but in
our case this is null.

I have no idea if this patch is correct.  Another plausible approach
would be to check stylesheet!=null before using it in strip().

I'd appreciate it if someone could look at this rather quickly.  It
breaks Eclipse in FC6.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[tromey at gcc dot gnu dot org]

------- Comment #6 from tromey at gcc dot gnu dot org  2006-10-10 19:32 -------
Subject: Bug 29362

Author: tromey
Date: Tue Oct 10 19:31:56 2006
New Revision: 117612

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117612
Log:
        PR classpath/29362:
        * gnu/xml/transform/TransformerImpl.java (transform): Only strip if
        there is a stylesheet.

Modified:
    trunk/libjava/classpath/ChangeLog.gcj
    trunk/libjava/classpath/gnu/xml/transform/TransformerImpl.java


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[jjohnstn at redhat dot com]

------- Comment #7 from jjohnstn at redhat dot com  2006-10-10 19:35 -------
I am confirming that the patch does fix the problem.  With patch, the original
Eclipse CDT problems have gone away.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[tromey at gcc dot gnu dot org]

------- Comment #8 from tromey at gcc dot gnu dot org  2006-10-10 19:38 -------
Subject: Bug 29362

Author: tromey
Date: Tue Oct 10 19:37:52 2006
New Revision: 117613

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117613
Log:
        PR classpath/29362:
        * gnu/xml/transform/TransformerImpl.java (transform): Only strip if
        there is a stylesheet.

Modified:
    branches/redhat/gcc-4_1-branch/libjava/classpath/ChangeLog.gcj
   
branches/redhat/gcc-4_1-branch/libjava/classpath/gnu/xml/transform/TransformerImpl.java


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362

[Bug xml/29362] NullPointerException in gnu.xml.transform.TransformerImpl.strip(libgcj.so.7rh)

[tromey at gcc dot gnu dot org]

------- Comment #9 from tromey at gcc dot gnu dot org  2006-10-10 19:39 -------
I checked this in.
I'd still appreciate a review from Chris though.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |0.93


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29362